Built by Maven

Checkstyle Results

The following document contains the results of Checkstyle 10.14.0 with struts_checks.xml ruleset.

Summary

Files  Info  Warnings  Errors
20 0 0 262

Files

File  I  W  E
org/apache/struts/extras/actions/ActionDispatcher.java 0 0 48
org/apache/struts/extras/actions/BaseAction.java 0 0 1
org/apache/struts/extras/actions/DispatchAction.java 0 0 34
org/apache/struts/extras/actions/DownloadAction.java 0 0 14
org/apache/struts/extras/actions/EventActionDispatcher.java 0 0 14
org/apache/struts/extras/actions/EventDispatchAction.java 0 0 13
org/apache/struts/extras/actions/ForwardAction.java 0 0 7
org/apache/struts/extras/actions/IncludeAction.java 0 0 7
org/apache/struts/extras/actions/LocalStrings.properties 0 0 1
org/apache/struts/extras/actions/LocalStrings_es.properties 0 0 1
org/apache/struts/extras/actions/LocalStrings_ja.properties 0 0 1
org/apache/struts/extras/actions/LocaleAction.java 0 0 7
org/apache/struts/extras/actions/LookupDispatchAction.java 0 0 17
org/apache/struts/extras/actions/MappingDispatchAction.java 0 0 22
org/apache/struts/extras/actions/SwitchAction.java 0 0 8
org/apache/struts/extras/actions/package-info.java 0 0 2
org/apache/struts/extras/plugins/DigestingPlugIn.java 0 0 44
org/apache/struts/extras/plugins/ModuleConfigVerifier.java 0 0 14
org/apache/struts/extras/validator/DynaValidatorActionForm.java 0 0 3
org/apache/struts/extras/validator/ValidatorActionForm.java 0 0 4

Rules

Category Rule Violations Severity
coding EmptyStatement 1  Error
design DesignForExtension 1  Error
header RegexpHeader
  • header
    1: /
    2: *
    3: s*
    4: 
    5: *
    6: s*
    7: $Id.*
    8: $
    9: 
    10: *
    11: s*
    12: 
    13: *
    14: s*Copyright
    15: d{4}(-
    16: d{4}|,
    17: d{4})* The Apache Software Fou
    18: datio
    19: .
    20: 
    21: *
    22: s*
    23: 
    24: *
    25: s*Lice
    26: sed u
    27: der the Apache Lice
    28: se, Versio
    29:  2
    30: .0
    31: (the .Lice
    32: se.
    33: );
    34: 
    35: *
    36: s*you may
    37: ot use this file except i
    38:  complia
    39: ce with the Lice
    40: se
    41: .
    42: 
    43: *
    44: s*You may obtai
    45:  a copy of the Lice
    46: se at
    47: 
    48: *
    49: s*
    50: 
    51: *
    52: s*http://www
    53: .apache
    54: .org/lice
    55: ses/LICENSE
    56: -2
    57: .0
    58: 
    59: *
    60: s*
    61: 
    62: *
    63: s*U
    64: less required by applicable law or agreed to i
    65:  writi
    66: g, software
    67: 
    68: *
    69: s*distributed u
    70: der the Lice
    71: se is distributed o
    72:  a
    73:  .AS IS. BASIS,
    74: 
    75: *
    76: s*WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied
    77: .
    78: 
    79: *
    80: s*See the Lice
    81: se for the specific la
    82: guage gover
    83: i
    84: g permissio
    85: s a
    86: d
    87: 
    88: *
    89: s*limitatio
    90: s u
    91: der the Lice
    92: se
    93: .
    94: 
    95: */
    96: s*
 20  Error
imports UnusedImports
  • processJavadoc: "false"
 2  Error
javadoc JavadocMethod
  • validateThrows: "true"
 31  Error
JavadocPackage
  • allowLegacy: "true"
 2  Error
JavadocVariable 12  Error
MissingJavadocMethod 1  Error
misc FinalParameters 167  Error
NewlineAtEndOfFile 14  Error
TodoComment 1  Error
modifier ModifierOrder 8  Error
RedundantModifier 1  Error
whitespace NoWhitespaceBefore 1  Error

Details

org/apache/struts/extras/actions/ActionDispatcher.java

Severity Category Rule Message Line
 Error misc NewlineAtEndOfFile File does not end with a newline. 1
 Error header RegexpHeader Line does not match expected header line of ' \*\s*Copyright \d{4}(-\d{4}|,\d{4})* The Apache Software Foundation\.'. 4
 Error modifier ModifierOrder 'final' modifier out of order with the JLS suggestions. 115
 Error misc FinalParameters Parameter actionInstance should be final. 165
 Error misc FinalParameters Parameter actionInstance should be final. 175
 Error misc FinalParameters Parameter flavor should be final. 175
 Error misc FinalParameters Parameter mapping should be final. 199
 Error misc FinalParameters Parameter form should be final. 199
 Error misc FinalParameters Parameter request should be final. 200
 Error misc FinalParameters Parameter response should be final. 200
 Error javadoc JavadocMethod Expected @throws tag for 'ServletException'. 224
 Error misc FinalParameters Parameter mapping should be final. 247
 Error misc FinalParameters Parameter form should be final. 247
 Error misc FinalParameters Parameter request should be final. 248
 Error misc FinalParameters Parameter response should be final. 248
 Error javadoc JavadocMethod Expected @throws tag for 'ServletException'. 263
 Error misc FinalParameters Parameter mapping should be final. 284
 Error misc FinalParameters Parameter form should be final. 284
 Error misc FinalParameters Parameter request should be final. 285
 Error misc FinalParameters Parameter response should be final. 285
 Error misc FinalParameters Parameter mapping should be final. 315
 Error misc FinalParameters Parameter form should be final. 316
 Error misc FinalParameters Parameter request should be final. 316
 Error misc FinalParameters Parameter response should be final. 317
 Error misc FinalParameters Parameter name should be final. 317
 Error misc FinalParameters Parameter mapping should be final. 359
 Error misc FinalParameters Parameter form should be final. 360
 Error misc FinalParameters Parameter request should be final. 360
 Error misc FinalParameters Parameter response should be final. 361
 Error misc FinalParameters Parameter name should be final. 361
 Error misc FinalParameters Parameter method should be final. 361
 Error javadoc JavadocMethod Expected @throws tag for 'ServletException'. 391
 Error misc FinalParameters Parameter name should be final. 408
 Error misc FinalParameters Parameter mapping should be final. 433
 Error misc FinalParameters Parameter form should be final. 433
 Error misc FinalParameters Parameter request should be final. 434
 Error misc FinalParameters Parameter response should be final. 434
 Error javadoc JavadocMethod Expected @throws tag for 'ServletException'. 454
 Error misc FinalParameters Parameter mapping should be final. 472
 Error misc FinalParameters Parameter form should be final. 472
 Error misc FinalParameters Parameter request should be final. 473
 Error misc FinalParameters Parameter response should be final. 473
 Error misc FinalParameters Parameter parameter should be final. 474
 Error misc FinalParameters Parameter request should be final. 498
 Error javadoc JavadocMethod @return tag should be present and have description. 505
 Error misc FinalParameters Parameter context should be final. 505
 Error javadoc JavadocMethod Expected @param tag for 'context'. 505
 Error javadoc JavadocMethod Expected @throws tag for 'Exception'. 505

org/apache/struts/extras/actions/BaseAction.java

Severity Category Rule Message Line
 Error header RegexpHeader Line does not match expected header line of ' \*\s*Copyright \d{4}(-\d{4}|,\d{4})* The Apache Software Foundation\.'. 4

org/apache/struts/extras/actions/DispatchAction.java

Severity Category Rule Message Line
 Error misc NewlineAtEndOfFile File does not end with a newline. 1
 Error header RegexpHeader Line does not match expected header line of ' \*\s*Copyright \d{4}(-\d{4}|,\d{4})* The Apache Software Foundation\.'. 4
 Error modifier ModifierOrder 'final' modifier out of order with the JLS suggestions. 100
 Error misc FinalParameters Parameter mapping should be final. 145
 Error misc FinalParameters Parameter form should be final. 145
 Error misc FinalParameters Parameter request should be final. 146
 Error misc FinalParameters Parameter response should be final. 146
 Error javadoc JavadocMethod Expected @throws tag for 'ServletException'. 169
 Error misc FinalParameters Parameter mapping should be final. 191
 Error misc FinalParameters Parameter form should be final. 191
 Error misc FinalParameters Parameter request should be final. 192
 Error misc FinalParameters Parameter response should be final. 192
 Error javadoc JavadocMethod Expected @throws tag for 'ServletException'. 200
 Error misc FinalParameters Parameter mapping should be final. 219
 Error misc FinalParameters Parameter form should be final. 219
 Error misc FinalParameters Parameter request should be final. 220
 Error misc FinalParameters Parameter response should be final. 220
 Error misc FinalParameters Parameter mapping should be final. 241
 Error misc FinalParameters Parameter form should be final. 242
 Error misc FinalParameters Parameter request should be final. 242
 Error misc FinalParameters Parameter response should be final. 243
 Error misc FinalParameters Parameter name should be final. 243
 Error javadoc JavadocMethod Expected @throws tag for 'ServletException'. 296
 Error misc FinalParameters Parameter mapping should be final. 314
 Error misc FinalParameters Parameter form should be final. 314
 Error misc FinalParameters Parameter request should be final. 315
 Error misc FinalParameters Parameter response should be final. 315
 Error javadoc JavadocMethod Expected @throws tag for 'ServletException'. 327
 Error misc FinalParameters Parameter name should be final. 343
 Error misc FinalParameters Parameter mapping should be final. 370
 Error misc FinalParameters Parameter form should be final. 370
 Error misc FinalParameters Parameter request should be final. 371
 Error misc FinalParameters Parameter response should be final. 371
 Error misc FinalParameters Parameter parameter should be final. 372

org/apache/struts/extras/actions/DownloadAction.java

Severity Category Rule Message Line
 Error misc NewlineAtEndOfFile File does not end with a newline. 1
 Error header RegexpHeader Line does not match expected header line of ' \*\s*Copyright \d{4}(-\d{4}|,\d{4})* The Apache Software Foundation\.'. 4
 Error misc FinalParameters Parameter mapping should be final. 103
 Error misc FinalParameters Parameter form should be final. 103
 Error misc FinalParameters Parameter request should be final. 104
 Error misc FinalParameters Parameter response should be final. 104
 Error misc FinalParameters Parameter input should be final. 127
 Error misc FinalParameters Parameter output should be final. 127
 Error modifier RedundantModifier Redundant 'static' modifier. 145
 Error misc FinalParameters Parameter contentType should be final. 186
 Error misc FinalParameters Parameter file should be final. 186
 Error misc FinalParameters Parameter contentType should be final. 244
 Error misc FinalParameters Parameter context should be final. 244
 Error misc FinalParameters Parameter path should be final. 245

org/apache/struts/extras/actions/EventActionDispatcher.java

Severity Category Rule Message Line
 Error misc NewlineAtEndOfFile File does not end with a newline. 1
 Error header RegexpHeader Line does not match expected header line of ' \*\s*Copyright \d{4}(-\d{4}|,\d{4})* The Apache Software Foundation\.'. 4
 Error modifier ModifierOrder 'final' modifier out of order with the JLS suggestions. 105
 Error misc FinalParameters Parameter action should be final. 118
 Error misc FinalParameters Parameter mapping should be final. 141
 Error misc FinalParameters Parameter form should be final. 141
 Error misc FinalParameters Parameter request should be final. 142
 Error misc FinalParameters Parameter response should be final. 142
 Error javadoc JavadocMethod Expected @throws tag for 'ServletException'. 156
 Error misc FinalParameters Parameter mapping should be final. 174
 Error misc FinalParameters Parameter form should be final. 174
 Error misc FinalParameters Parameter request should be final. 175
 Error misc FinalParameters Parameter response should be final. 175
 Error misc FinalParameters Parameter parameter should be final. 176

org/apache/struts/extras/actions/EventDispatchAction.java

Severity Category Rule Message Line
 Error misc NewlineAtEndOfFile File does not end with a newline. 1
 Error header RegexpHeader Line does not match expected header line of ' \*\s*Copyright \d{4}(-\d{4}|,\d{4})* The Apache Software Foundation\.'. 4
 Error modifier ModifierOrder 'final' modifier out of order with the JLS suggestions. 83
 Error misc FinalParameters Parameter mapping should be final. 109
 Error misc FinalParameters Parameter form should be final. 109
 Error misc FinalParameters Parameter request should be final. 110
 Error misc FinalParameters Parameter response should be final. 110
 Error javadoc JavadocMethod Expected @throws tag for 'ServletException'. 118
 Error misc FinalParameters Parameter mapping should be final. 133
 Error misc FinalParameters Parameter form should be final. 133
 Error misc FinalParameters Parameter request should be final. 134
 Error misc FinalParameters Parameter response should be final. 134
 Error misc FinalParameters Parameter parameter should be final. 135

org/apache/struts/extras/actions/ForwardAction.java

Severity Category Rule Message Line
 Error misc NewlineAtEndOfFile File does not end with a newline. 1
 Error header RegexpHeader Line does not match expected header line of ' \*\s*Copyright \d{4}(-\d{4}|,\d{4})* The Apache Software Foundation\.'. 4
 Error misc FinalParameters Parameter mapping should be final. 73
 Error misc FinalParameters Parameter form should be final. 73
 Error misc FinalParameters Parameter request should be final. 74
 Error misc FinalParameters Parameter response should be final. 74
 Error javadoc JavadocMethod Expected @throws tag for 'ServletException'. 80

org/apache/struts/extras/actions/IncludeAction.java

Severity Category Rule Message Line
 Error misc NewlineAtEndOfFile File does not end with a newline. 1
 Error header RegexpHeader Line does not match expected header line of ' \*\s*Copyright \d{4}(-\d{4}|,\d{4})* The Apache Software Foundation\.'. 4
 Error misc FinalParameters Parameter mapping should be final. 74
 Error misc FinalParameters Parameter form should be final. 74
 Error misc FinalParameters Parameter request should be final. 75
 Error misc FinalParameters Parameter response should be final. 75
 Error javadoc JavadocMethod Expected @throws tag for 'ServletException'. 81

org/apache/struts/extras/actions/LocalStrings.properties

Severity Category Rule Message Line
 Error header RegexpHeader Line does not match expected header line of '/\*\s*'. 1

org/apache/struts/extras/actions/LocalStrings_es.properties

Severity Category Rule Message Line
 Error header RegexpHeader Line does not match expected header line of '/\*\s*'. 1

org/apache/struts/extras/actions/LocalStrings_ja.properties

Severity Category Rule Message Line
 Error header RegexpHeader Line does not match expected header line of '/\*\s*'. 1

org/apache/struts/extras/actions/LocaleAction.java

Severity Category Rule Message Line
 Error misc NewlineAtEndOfFile File does not end with a newline. 1
 Error header RegexpHeader Line does not match expected header line of ' \*\s*Copyright \d{4}(-\d{4}|,\d{4})* The Apache Software Foundation\.'. 4
 Error modifier ModifierOrder 'final' modifier out of order with the JLS suggestions. 48
 Error misc FinalParameters Parameter mapping should be final. 69
 Error misc FinalParameters Parameter form should be final. 69
 Error misc FinalParameters Parameter request should be final. 70
 Error misc FinalParameters Parameter response should be final. 70

org/apache/struts/extras/actions/LookupDispatchAction.java

Severity Category Rule Message Line
 Error misc NewlineAtEndOfFile File does not end with a newline. 1
 Error header RegexpHeader Line does not match expected header line of ' \*\s*Copyright \d{4}(-\d{4}|,\d{4})* The Apache Software Foundation\.'. 4
 Error modifier ModifierOrder 'final' modifier out of order with the JLS suggestions. 115
 Error misc FinalParameters Parameter mapping should be final. 144
 Error misc FinalParameters Parameter form should be final. 144
 Error misc FinalParameters Parameter request should be final. 145
 Error misc FinalParameters Parameter response should be final. 145
 Error misc FinalParameters Parameter request should be final. 159
 Error misc FinalParameters Parameter userLocale should be final. 159
 Error misc FinalParameters Parameter request should be final. 206
 Error misc FinalParameters Parameter keyName should be final. 207
 Error misc FinalParameters Parameter mapping should be final. 207
 Error misc FinalParameters Parameter mapping should be final. 259
 Error misc FinalParameters Parameter form should be final. 259
 Error misc FinalParameters Parameter request should be final. 260
 Error misc FinalParameters Parameter response should be final. 260
 Error misc FinalParameters Parameter parameter should be final. 261

org/apache/struts/extras/actions/MappingDispatchAction.java

Severity Category Rule Message Line
 Error misc NewlineAtEndOfFile File does not end with a newline. 1
 Error header RegexpHeader Line does not match expected header line of ' \*\s*Copyright \d{4}(-\d{4}|,\d{4})* The Apache Software Foundation\.'. 4
 Error modifier ModifierOrder 'final' modifier out of order with the JLS suggestions. 140
 Error misc FinalParameters Parameter mapping should be final. 165
 Error misc FinalParameters Parameter form should be final. 165
 Error misc FinalParameters Parameter request should be final. 166
 Error misc FinalParameters Parameter response should be final. 166
 Error misc FinalParameters Parameter mapping should be final. 187
 Error misc FinalParameters Parameter form should be final. 187
 Error misc FinalParameters Parameter request should be final. 188
 Error misc FinalParameters Parameter response should be final. 188
 Error javadoc JavadocMethod Expected @throws tag for 'ServletException'. 195
 Error misc FinalParameters Parameter mapping should be final. 207
 Error misc FinalParameters Parameter form should be final. 207
 Error misc FinalParameters Parameter request should be final. 208
 Error misc FinalParameters Parameter response should be final. 208
 Error javadoc JavadocMethod Expected @throws tag for 'Exception'. 209
 Error misc FinalParameters Parameter mapping should be final. 228
 Error misc FinalParameters Parameter form should be final. 228
 Error misc FinalParameters Parameter request should be final. 229
 Error misc FinalParameters Parameter response should be final. 229
 Error misc FinalParameters Parameter parameter should be final. 230

org/apache/struts/extras/actions/SwitchAction.java

Severity Category Rule Message Line
 Error misc NewlineAtEndOfFile File does not end with a newline. 1
 Error header RegexpHeader Line does not match expected header line of ' \*\s*Copyright \d{4}(-\d{4}|,\d{4})* The Apache Software Foundation\.'. 4
 Error modifier ModifierOrder 'final' modifier out of order with the JLS suggestions. 67
 Error misc FinalParameters Parameter mapping should be final. 86
 Error misc FinalParameters Parameter form should be final. 86
 Error misc FinalParameters Parameter request should be final. 87
 Error misc FinalParameters Parameter response should be final. 87
 Error javadoc JavadocMethod Expected @throws tag for 'ServletException'. 97

org/apache/struts/extras/actions/package-info.java

Severity Category Rule Message Line
 Error misc NewlineAtEndOfFile File does not end with a newline. 1
 Error header RegexpHeader Line does not match expected header line of ' \*\s*Copyright \d{4}(-\d{4}|,\d{4})* The Apache Software Foundation\.'. 4

org/apache/struts/extras/plugins/DigestingPlugIn.java

Severity Category Rule Message Line
 Error misc NewlineAtEndOfFile File does not end with a newline. 1
 Error javadoc JavadocPackage Missing package-info.java file. 1
 Error header RegexpHeader Line does not match expected header line of ' \*\s*Copyright \d{4}(-\d{4}|,\d{4})* The Apache Software Foundation\.'. 4
 Error imports UnusedImports Unused import - java.io.FileNotFoundException. 24
 Error imports UnusedImports Unused import - java.net.MalformedURLException. 27
 Error javadoc JavadocVariable Missing a Javadoc comment. 61
 Error javadoc JavadocVariable Missing a Javadoc comment. 62
 Error javadoc JavadocVariable Missing a Javadoc comment. 63
 Error javadoc JavadocVariable Missing a Javadoc comment. 64
 Error javadoc JavadocVariable Missing a Javadoc comment. 65
 Error javadoc JavadocVariable Missing a Javadoc comment. 66
 Error javadoc JavadocVariable Missing a Javadoc comment. 67
 Error javadoc JavadocVariable Missing a Javadoc comment. 68
 Error javadoc JavadocVariable Missing a Javadoc comment. 69
 Error javadoc JavadocVariable Missing a Javadoc comment. 70
 Error javadoc JavadocVariable Missing a Javadoc comment. 71
 Error javadoc JavadocVariable Missing a Javadoc comment. 72
 Error misc FinalParameters Parameter servlet should be final. 101
 Error misc FinalParameters Parameter config should be final. 101
 Error misc FinalParameters Parameter path should be final. 211
 Error misc FinalParameters Parameter source should be final. 211
 Error javadoc JavadocMethod Expected @throws tag for 'IOException'. 212
 Error javadoc JavadocMethod Expected @throws tag for 'NullPointerException'. 216
 Error misc FinalParameters Parameter digester should be final. 239
 Error whitespace NoWhitespaceBefore ',' is preceded with whitespace. 262
 Error misc FinalParameters Parameter path should be final. 301
 Error misc FinalParameters Parameter source should be final. 301
 Error javadoc JavadocMethod Expected @throws tag for 'IOException'. 302
 Error javadoc JavadocMethod Expected @throws tag for 'IllegalArgumentException'. 316
 Error misc FinalParameters Parameter path should be final. 327
 Error misc FinalParameters Parameter path should be final. 339
 Error javadoc JavadocMethod Expected @throws tag for 'IOException'. 340
 Error misc FinalParameters Parameter path should be final. 352
 Error javadoc JavadocMethod Expected @throws tag for 'IOException'. 353
 Error misc FinalParameters Parameter configPath should be final. 364
 Error misc FinalParameters Parameter configSource should be final. 386
 Error misc FinalParameters Parameter obj should be final. 407
 Error misc FinalParameters Parameter key should be final. 417
 Error misc FinalParameters Parameter ruleSets should be final. 433
 Error javadoc JavadocMethod Expected @param tag for 'ruleSets'. 433
 Error misc FinalParameters Parameter digesterPath should be final. 451
 Error javadoc JavadocMethod Expected @param tag for 'digesterPath'. 451
 Error misc FinalParameters Parameter digesterSource should be final. 471
 Error misc FinalParameters Parameter push should be final. 491

org/apache/struts/extras/plugins/ModuleConfigVerifier.java

Severity Category Rule Message Line
 Error misc NewlineAtEndOfFile File does not end with a newline. 1
 Error header RegexpHeader Line does not match expected header line of ' \*\s*Copyright \d{4}(-\d{4}|,\d{4})* The Apache Software Foundation\.'. 4
 Error javadoc JavadocMethod @return tag should be present and have description. 77
 Error misc FinalParameters Parameter fatal should be final. 86
 Error coding EmptyStatement Empty statement. 96
 Error design DesignForExtension Class 'ModuleConfigVerifier' looks like designed for extension (can be subclassed), but the method 'init' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'ModuleConfigVerifier' final or making the method 'init' static/final/abstract/empty, or adding allowed annotation for the method. 100
 Error javadoc MissingJavadocMethod Missing a Javadoc comment. 100
 Error misc FinalParameters Parameter servlet should be final. 100
 Error misc FinalParameters Parameter config should be final. 100
 Error misc TodoComment Comment matches to-do format 'TODO:'. 110
 Error javadoc JavadocMethod @return tag should be present and have description. 159
 Error javadoc JavadocMethod @return tag should be present and have description. 185
 Error javadoc JavadocMethod @return tag should be present and have description. 210
 Error javadoc JavadocMethod @return tag should be present and have description. 245

org/apache/struts/extras/validator/DynaValidatorActionForm.java

Severity Category Rule Message Line
 Error header RegexpHeader Line does not match expected header line of ' \*\s*Copyright \d{4}(-\d{4}|,\d{4})* The Apache Software Foundation\.'. 4
 Error misc FinalParameters Parameter mapping should be final. 60
 Error misc FinalParameters Parameter request should be final. 61

org/apache/struts/extras/validator/ValidatorActionForm.java

Severity Category Rule Message Line
 Error javadoc JavadocPackage Missing package-info.java file. 1
 Error header RegexpHeader Line does not match expected header line of ' \*\s*Copyright \d{4}(-\d{4}|,\d{4})* The Apache Software Foundation\.'. 4
 Error misc FinalParameters Parameter mapping should be final. 58
 Error misc FinalParameters Parameter request should be final. 59