Built by Maven

Checkstyle Results

The following document contains the results of Checkstyle 10.14.0 with struts_checks.xml ruleset.

Summary

Files  Info  Warnings  Errors
12 0 0 106

Files

File  I  W  E
org/apache/struts/tiles2/TilesPlugin.java 0 0 9
org/apache/struts/tiles2/TilesPluginContainer.java 0 0 10
org/apache/struts/tiles2/TilesPluginContainerFactory.java 0 0 12
org/apache/struts/tiles2/TilesRequestProcessor.java 0 0 20
org/apache/struts/tiles2/actions/DefinitionDispatcherAction.java 0 0 7
org/apache/struts/tiles2/actions/TilesAction.java 0 0 13
org/apache/struts/tiles2/commands/TilesPreProcessor.java 0 0 4
org/apache/struts/tiles2/package-info.java 0 0 13
org/apache/struts/tiles2/preparer/ActionPreparer.java 0 0 4
org/apache/struts/tiles2/preparer/StrutsPreparerFactory.java 0 0 2
org/apache/struts/tiles2/preparer/UrlPreparer.java 0 0 5
org/apache/struts/tiles2/util/PlugInConfigContextAdapter.java 0 0 7

Rules

Category Rule Violations Severity
design DesignForExtension 4  Error
header RegexpHeader
  • header
    1: /
    2: *
    3: s*
    4: 
    5: *
    6: s*
    7: $Id.*
    8: $
    9: 
    10: *
    11: s*
    12: 
    13: *
    14: s*Copyright
    15: d{4}(-
    16: d{4}|,
    17: d{4})* The Apache Software Fou
    18: datio
    19: .
    20: 
    21: *
    22: s*
    23: 
    24: *
    25: s*Lice
    26: sed u
    27: der the Apache Lice
    28: se, Versio
    29:  2
    30: .0
    31: (the .Lice
    32: se.
    33: );
    34: 
    35: *
    36: s*you may
    37: ot use this file except i
    38:  complia
    39: ce with the Lice
    40: se
    41: .
    42: 
    43: *
    44: s*You may obtai
    45:  a copy of the Lice
    46: se at
    47: 
    48: *
    49: s*
    50: 
    51: *
    52: s*http://www
    53: .apache
    54: .org/lice
    55: ses/LICENSE
    56: -2
    57: .0
    58: 
    59: *
    60: s*
    61: 
    62: *
    63: s*U
    64: less required by applicable law or agreed to i
    65:  writi
    66: g, software
    67: 
    68: *
    69: s*distributed u
    70: der the Lice
    71: se is distributed o
    72:  a
    73:  .AS IS. BASIS,
    74: 
    75: *
    76: s*WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied
    77: .
    78: 
    79: *
    80: s*See the Lice
    81: se for the specific la
    82: guage gover
    83: i
    84: g permissio
    85: s a
    86: d
    87: 
    88: *
    89: s*limitatio
    90: s u
    91: der the Lice
    92: se
    93: .
    94: 
    95: */
    96: s*
 12  Error
imports UnusedImports
  • processJavadoc: "false"
 1  Error
javadoc JavadocMethod
  • validateThrows: "true"
 2  Error
JavadocPackage
  • allowLegacy: "true"
 4  Error
misc FinalParameters 57  Error
NewlineAtEndOfFile 9  Error
modifier ModifierOrder 4  Error
naming LocalVariableName 1  Error
sizes LineLength
  • fileExtensions: "java"
  • max: "120"
  • ignorePattern: "^ \* @version .*$"
 11  Error
whitespace ParenPad 1  Error

Details

org/apache/struts/tiles2/TilesPlugin.java

Severity Category Rule Message Line
 Error misc NewlineAtEndOfFile File does not end with a newline. 1
 Error header RegexpHeader Line does not match expected header line of ' \*\s*Copyright \d{4}(-\d{4}|,\d{4})* The Apache Software Foundation\.'. 4
 Error modifier ModifierOrder 'static' modifier out of order with the JLS suggestions. 75
 Error misc FinalParameters Parameter moduleAware should be final. 116
 Error misc FinalParameters Parameter servlet should be final. 132
 Error misc FinalParameters Parameter moduleConfig should be final. 132
 Error javadoc JavadocMethod Expected @throws tag for 'IllegalStateException'. 190
 Error misc FinalParameters Parameter config should be final. 215
 Error misc FinalParameters Parameter plugInConfigObject should be final. 265

org/apache/struts/tiles2/TilesPluginContainer.java

Severity Category Rule Message Line
 Error misc NewlineAtEndOfFile File does not end with a newline. 1
 Error header RegexpHeader Line does not match expected header line of ' \*\s*Copyright \d{4}(-\d{4}|,\d{4})* The Apache Software Foundation\.'. 4
 Error misc FinalParameters Parameter localeResolver should be final. 58
 Error misc FinalParameters Parameter key should be final. 81
 Error misc FinalParameters Parameter key should be final. 99
 Error misc FinalParameters Parameter definitionsFactory should be final. 100
 Error design DesignForExtension Class 'TilesPluginContainer' looks like designed for extension (can be subclassed), but the method 'getDefinition' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'TilesPluginContainer' final or making the method 'getDefinition' static/final/abstract/empty, or adding allowed annotation for the method. 108
 Error misc FinalParameters Parameter definitionName should be final. 109
 Error misc FinalParameters Parameter request should be final. 110
 Error misc FinalParameters Parameter request should be final. 133

org/apache/struts/tiles2/TilesPluginContainerFactory.java

Severity Category Rule Message Line
 Error misc NewlineAtEndOfFile File does not end with a newline. 1
 Error header RegexpHeader Line does not match expected header line of ' \*\s*Copyright \d{4}(-\d{4}|,\d{4})* The Apache Software Foundation\.'. 4
 Error imports UnusedImports Unused import - org.apache.tiles.definition.UnresolvingLocaleDefinitionsFactory. 32
 Error modifier ModifierOrder 'final' modifier out of order with the JLS suggestions. 46
 Error design DesignForExtension Class 'TilesPluginContainerFactory' looks like designed for extension (can be subclassed), but the method 'createContainer' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'TilesPluginContainerFactory' final or making the method 'createContainer' static/final/abstract/empty, or adding allowed annotation for the method. 49
 Error misc FinalParameters Parameter applicationContext should be final. 50
 Error design DesignForExtension Class 'TilesPluginContainerFactory' looks like designed for extension (can be subclassed), but the method 'instantiateContainer' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'TilesPluginContainerFactory' final or making the method 'instantiateContainer' static/final/abstract/empty, or adding allowed annotation for the method. 67
 Error misc FinalParameters Parameter context should be final. 69
 Error misc FinalParameters Parameter applicationContext should be final. 82
 Error whitespace ParenPad ')' is preceded with whitespace. 95
 Error misc FinalParameters Parameter container should be final. 132
 Error misc FinalParameters Parameter applicationContext should be final. 133

org/apache/struts/tiles2/TilesRequestProcessor.java

Severity Category Rule Message Line
 Error misc NewlineAtEndOfFile File does not end with a newline. 1
 Error header RegexpHeader Line does not match expected header line of ' \*\s*Copyright \d{4}(-\d{4}|,\d{4})* The Apache Software Foundation\.'. 4
 Error modifier ModifierOrder 'final' modifier out of order with the JLS suggestions. 69
 Error misc FinalParameters Parameter servlet should be final. 84
 Error misc FinalParameters Parameter moduleConfig should be final. 84
 Error misc FinalParameters Parameter definitionName should be final. 108
 Error misc FinalParameters Parameter req should be final. 109
 Error misc FinalParameters Parameter res should be final. 110
 Error misc FinalParameters Parameter uri should be final. 154
 Error misc FinalParameters Parameter request should be final. 155
 Error misc FinalParameters Parameter response should be final. 156
 Error misc FinalParameters Parameter request should be final. 182
 Error misc FinalParameters Parameter response should be final. 183
 Error misc FinalParameters Parameter forward should be final. 184
 Error misc FinalParameters Parameter uri should be final. 226
 Error misc FinalParameters Parameter request should be final. 227
 Error misc FinalParameters Parameter response should be final. 228
 Error misc FinalParameters Parameter uri should be final. 254
 Error misc FinalParameters Parameter request should be final. 255
 Error misc FinalParameters Parameter response should be final. 256

org/apache/struts/tiles2/actions/DefinitionDispatcherAction.java

Severity Category Rule Message Line
 Error misc NewlineAtEndOfFile File does not end with a newline. 1
 Error header RegexpHeader Line does not match expected header line of ' \*\s*Copyright \d{4}(-\d{4}|,\d{4})* The Apache Software Foundation\.'. 4
 Error modifier ModifierOrder 'final' modifier out of order with the JLS suggestions. 75
 Error misc FinalParameters Parameter mapping should be final. 94
 Error misc FinalParameters Parameter form should be final. 95
 Error misc FinalParameters Parameter req should be final. 96
 Error misc FinalParameters Parameter res should be final. 97

org/apache/struts/tiles2/actions/TilesAction.java

Severity Category Rule Message Line
 Error misc NewlineAtEndOfFile File does not end with a newline. 1
 Error javadoc JavadocPackage Missing package-info.java file. 1
 Error header RegexpHeader Line does not match expected header line of ' \*\s*Copyright \d{4}(-\d{4}|,\d{4})* The Apache Software Foundation\.'. 4
 Error misc FinalParameters Parameter mapping should be final. 69
 Error misc FinalParameters Parameter form should be final. 70
 Error misc FinalParameters Parameter req should be final. 71
 Error misc FinalParameters Parameter res should be final. 72
 Error javadoc JavadocMethod Expected @throws tag for 'ServletException'. 83
 Error misc FinalParameters Parameter context should be final. 111
 Error misc FinalParameters Parameter mapping should be final. 112
 Error misc FinalParameters Parameter form should be final. 113
 Error misc FinalParameters Parameter request should be final. 114
 Error misc FinalParameters Parameter response should be final. 115

org/apache/struts/tiles2/commands/TilesPreProcessor.java

Severity Category Rule Message Line
 Error misc NewlineAtEndOfFile File does not end with a newline. 1
 Error javadoc JavadocPackage Missing package-info.java file. 1
 Error header RegexpHeader Line does not match expected header line of ' \*\s*Copyright \d{4}(-\d{4}|,\d{4})* The Apache Software Foundation\.'. 4
 Error misc FinalParameters Parameter sacontext should be final. 88

org/apache/struts/tiles2/package-info.java

Severity Category Rule Message Line
 Error misc NewlineAtEndOfFile File does not end with a newline. 1
 Error header RegexpHeader Line does not match expected header line of ' \*\s*Copyright \d{4}(-\d{4}|,\d{4})* The Apache Software Foundation\.'. 4
 Error sizes LineLength Line is longer than 120 characters (found 312). 34
 Error sizes LineLength Line is longer than 120 characters (found 455). 44
 Error sizes LineLength Line is longer than 120 characters (found 121). 55
 Error sizes LineLength Line is longer than 120 characters (found 154). 56
 Error sizes LineLength Line is longer than 120 characters (found 236). 73
 Error sizes LineLength Line is longer than 120 characters (found 134). 89
 Error sizes LineLength Line is longer than 120 characters (found 127). 90
 Error sizes LineLength Line is longer than 120 characters (found 142). 122
 Error sizes LineLength Line is longer than 120 characters (found 132). 209
 Error sizes LineLength Line is longer than 120 characters (found 167). 235
 Error sizes LineLength Line is longer than 120 characters (found 164). 261

org/apache/struts/tiles2/preparer/ActionPreparer.java

Severity Category Rule Message Line
 Error header RegexpHeader Line does not match expected header line of ' \*\s*Copyright \d{4}(-\d{4}|,\d{4})* The Apache Software Foundation\.'. 4
 Error misc FinalParameters Parameter action should be final. 48
 Error misc FinalParameters Parameter tilesContext should be final. 53
 Error misc FinalParameters Parameter attributeContext should be final. 54

org/apache/struts/tiles2/preparer/StrutsPreparerFactory.java

Severity Category Rule Message Line
 Error header RegexpHeader Line does not match expected header line of ' \*\s*Copyright \d{4}(-\d{4}|,\d{4})* The Apache Software Foundation\.'. 4
 Error misc FinalParameters Parameter name should be final. 38

org/apache/struts/tiles2/preparer/UrlPreparer.java

Severity Category Rule Message Line
 Error javadoc JavadocPackage Missing package-info.java file. 1
 Error header RegexpHeader Line does not match expected header line of ' \*\s*Copyright \d{4}(-\d{4}|,\d{4})* The Apache Software Foundation\.'. 4
 Error misc FinalParameters Parameter url should be final. 52
 Error misc FinalParameters Parameter tilesContext should be final. 57
 Error misc FinalParameters Parameter attributeContext should be final. 58

org/apache/struts/tiles2/util/PlugInConfigContextAdapter.java

Severity Category Rule Message Line
 Error misc NewlineAtEndOfFile File does not end with a newline. 1
 Error javadoc JavadocPackage Missing package-info.java file. 1
 Error header RegexpHeader Line does not match expected header line of ' \*\s*Copyright \d{4}(-\d{4}|,\d{4})* The Apache Software Foundation\.'. 4
 Error misc FinalParameters Parameter plugInConfigObject should be final. 56
 Error misc FinalParameters Parameter servletContext should be final. 57
 Error naming LocalVariableName Name 'initParam_' must match pattern '^[a-z][a-zA-Z0-9]*$'. 61
 Error design DesignForExtension Class 'PlugInConfigContextAdapter' looks like designed for extension (can be subclassed), but the method 'getInitParams' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'PlugInConfigContextAdapter' final or making the method 'getInitParams' static/final/abstract/empty, or adding allowed annotation for the method. 68