PMD Results

The following document contains the results of PMD 6.55.0.

Violations By Priority

Priority 3

org/apache/struts/tiles/AttributeDefinition.java
Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'public' on method 'getValue': the method is declared in an interface type 37
UnnecessaryModifier Unnecessary modifier 'public' on method 'setRole': the method is declared in an interface type 42
org/apache/struts/tiles/ComponentDefinitionsFactory.java
Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'public' on method 'getDefinition': the method is declared in an interface type 52
UnnecessaryModifier Unnecessary modifier 'public' on method 'initFactory': the method is declared in an interface type 63
org/apache/struts/tiles/Controller.java
Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'public' on method 'perform': the method is declared in an interface type 5156
UnnecessaryModifier Unnecessary modifier 'public' on method 'execute': the method is declared in an interface type 6772
org/apache/struts/tiles/DefinitionsFactory.java
Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'public' on method 'getDefinition': the method is declared in an interface type 5859
UnnecessaryModifier Unnecessary modifier 'public' on method 'init': the method is declared in an interface type 7071
UnnecessaryModifier Unnecessary modifier 'public' on method 'destroy': the method is declared in an interface type 77
UnnecessaryModifier Unnecessary modifier 'public' on method 'setConfig': the method is declared in an interface type 8990
UnnecessaryModifier Unnecessary modifier 'public' on method 'getConfig': the method is declared in an interface type 96
org/apache/struts/tiles/DefinitionsFactoryConfig.java
Rule Violation Line
UnusedFormalParameter Avoid unused constructor parameters such as 'initParameters'. 127
org/apache/struts/tiles/DefinitionsFactoryException.java
Rule Violation Line
UnusedFormalParameter Avoid unused constructor parameters such as 'e'. 56
org/apache/struts/tiles/beans/MenuItem.java
Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'public' on method 'setValue': the method is declared in an interface type 35
UnnecessaryModifier Unnecessary modifier 'public' on method 'getValue': the method is declared in an interface type 40
UnnecessaryModifier Unnecessary modifier 'public' on method 'setLink': the method is declared in an interface type 45
UnnecessaryModifier Unnecessary modifier 'public' on method 'getLink': the method is declared in an interface type 50
UnnecessaryModifier Unnecessary modifier 'public' on method 'setIcon': the method is declared in an interface type 55
UnnecessaryModifier Unnecessary modifier 'public' on method 'getIcon': the method is declared in an interface type 60
UnnecessaryModifier Unnecessary modifier 'public' on method 'setTooltip': the method is declared in an interface type 65
UnnecessaryModifier Unnecessary modifier 'public' on method 'getTooltip': the method is declared in an interface type 70
org/apache/struts/tiles/taglib/ComponentConstants.java
Rule Violation Line
UnnecessaryModifier Unnecessary modifiers 'public static final' on field 'COMPONENT_CONTEXT': the field is declared in an interface type 32
UnnecessaryModifier Unnecessary modifiers 'public static final' on field 'COMPONENT_SCOPE': the field is declared in an interface type 34
UnnecessaryModifier Unnecessary modifiers 'public static final' on field 'LOCALE_KEY': the field is declared in an interface type 35
UnnecessaryModifier Unnecessary modifiers 'public static final' on field 'EXCEPTION_KEY': the field is declared in an interface type 36
org/apache/struts/tiles/taglib/ImportAttributeTag.java
Rule Violation Line
CollapsibleIfStatements These nested if statements could be combined 195198
org/apache/struts/tiles/taglib/InsertTag.java
Rule Violation Line
EmptyCatchBlock Avoid empty catch blocks 718720
UnnecessaryModifier Unnecessary modifier 'public' on method 'doStartTag': the method is declared in an interface type 774
UnnecessaryModifier Unnecessary modifier 'public' on method 'doEndTag': the method is declared in an interface type 778
UnnecessaryModifier Unnecessary modifier 'public' on method 'putAttribute': the method is declared in an interface type 782
org/apache/struts/tiles/xmlDefinition/I18nFactorySet.java
Rule Violation Line
EmptyCatchBlock Avoid empty catch blocks 209211
EmptyCatchBlock Avoid empty catch blocks 493494
UnconditionalIfStatement Do not use if statements that are always true or always false 512

Priority 4

org/apache/struts/tiles/TilesRequestProcessor.java
Rule Violation Line
UselessParentheses Useless parentheses. 176
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'java.lang.InstantiationException' due to existing implicit import 'java.lang.*' 232
org/apache/struts/tiles/TilesUtilImpl.java
Rule Violation Line
UselessParentheses Useless parentheses. 139
UselessParentheses Useless parentheses. 141
org/apache/struts/tiles/actions/ReloadDefinitionsAction.java
Rule Violation Line
UselessParentheses Useless parentheses. 91
org/apache/struts/tiles/actions/ViewDefinitionsAction.java
Rule Violation Line
UselessParentheses Useless parentheses. 85
org/apache/struts/tiles/commands/TilesPreProcessor.java
Rule Violation Line
UselessParentheses Useless parentheses. 101
UselessParentheses Useless parentheses. 131
UselessParentheses Useless parentheses. 215
org/apache/struts/tiles/definition/ComponentDefinitionsFactoryWrapper.java
Rule Violation Line
UselessParentheses Useless parentheses. 219
org/apache/struts/tiles/taglib/AttributeToScopeTag.java
Rule Violation Line
UselessParentheses Useless parentheses. 71
UselessParentheses Useless parentheses. 139
org/apache/struts/tiles/taglib/DefinitionTag.java
Rule Violation Line
UselessParentheses Useless parentheses. 110
org/apache/struts/tiles/taglib/ImportAttributeTag.java
Rule Violation Line
UselessParentheses Useless parentheses. 86
UselessParentheses Useless parentheses. 215
org/apache/struts/tiles/taglib/PutListTag.java
Rule Violation Line
UselessParentheses Useless parentheses. 165
org/apache/struts/tiles/taglib/PutTag.java
Rule Violation Line
UselessParentheses Useless parentheses. 456
org/apache/struts/tiles/taglib/UseAttributeTag.java
Rule Violation Line
UselessParentheses Useless parentheses. 98
UselessParentheses Useless parentheses. 212

Files

org/apache/struts/tiles/AttributeDefinition.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifier 'public' on method 'getValue': the method is declared in an interface type 3 37
UnnecessaryModifier Unnecessary modifier 'public' on method 'setRole': the method is declared in an interface type 3 42

org/apache/struts/tiles/ComponentDefinitionsFactory.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifier 'public' on method 'getDefinition': the method is declared in an interface type 3 52
UnnecessaryModifier Unnecessary modifier 'public' on method 'initFactory': the method is declared in an interface type 3 63

org/apache/struts/tiles/Controller.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifier 'public' on method 'perform': the method is declared in an interface type 3 5156
UnnecessaryModifier Unnecessary modifier 'public' on method 'execute': the method is declared in an interface type 3 6772

org/apache/struts/tiles/DefinitionsFactory.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifier 'public' on method 'getDefinition': the method is declared in an interface type 3 5859
UnnecessaryModifier Unnecessary modifier 'public' on method 'init': the method is declared in an interface type 3 7071
UnnecessaryModifier Unnecessary modifier 'public' on method 'destroy': the method is declared in an interface type 3 77
UnnecessaryModifier Unnecessary modifier 'public' on method 'setConfig': the method is declared in an interface type 3 8990
UnnecessaryModifier Unnecessary modifier 'public' on method 'getConfig': the method is declared in an interface type 3 96

org/apache/struts/tiles/DefinitionsFactoryConfig.java

Rule Violation Priority Line
UnusedFormalParameter Avoid unused constructor parameters such as 'initParameters'. 3 127

org/apache/struts/tiles/DefinitionsFactoryException.java

Rule Violation Priority Line
UnusedFormalParameter Avoid unused constructor parameters such as 'e'. 3 56

org/apache/struts/tiles/TilesRequestProcessor.java

Rule Violation Priority Line
UselessParentheses Useless parentheses. 4 176
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'java.lang.InstantiationException' due to existing implicit import 'java.lang.*' 4 232

org/apache/struts/tiles/TilesUtilImpl.java

Rule Violation Priority Line
UselessParentheses Useless parentheses. 4 139
UselessParentheses Useless parentheses. 4 141

org/apache/struts/tiles/actions/ReloadDefinitionsAction.java

Rule Violation Priority Line
UselessParentheses Useless parentheses. 4 91

org/apache/struts/tiles/actions/ViewDefinitionsAction.java

Rule Violation Priority Line
UselessParentheses Useless parentheses. 4 85

org/apache/struts/tiles/beans/MenuItem.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifier 'public' on method 'setValue': the method is declared in an interface type 3 35
UnnecessaryModifier Unnecessary modifier 'public' on method 'getValue': the method is declared in an interface type 3 40
UnnecessaryModifier Unnecessary modifier 'public' on method 'setLink': the method is declared in an interface type 3 45
UnnecessaryModifier Unnecessary modifier 'public' on method 'getLink': the method is declared in an interface type 3 50
UnnecessaryModifier Unnecessary modifier 'public' on method 'setIcon': the method is declared in an interface type 3 55
UnnecessaryModifier Unnecessary modifier 'public' on method 'getIcon': the method is declared in an interface type 3 60
UnnecessaryModifier Unnecessary modifier 'public' on method 'setTooltip': the method is declared in an interface type 3 65
UnnecessaryModifier Unnecessary modifier 'public' on method 'getTooltip': the method is declared in an interface type 3 70

org/apache/struts/tiles/commands/TilesPreProcessor.java

Rule Violation Priority Line
UselessParentheses Useless parentheses. 4 101
UselessParentheses Useless parentheses. 4 131
UselessParentheses Useless parentheses. 4 215

org/apache/struts/tiles/definition/ComponentDefinitionsFactoryWrapper.java

Rule Violation Priority Line
UselessParentheses Useless parentheses. 4 219

org/apache/struts/tiles/taglib/AttributeToScopeTag.java

Rule Violation Priority Line
UselessParentheses Useless parentheses. 4 71
UselessParentheses Useless parentheses. 4 139

org/apache/struts/tiles/taglib/ComponentConstants.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifiers 'public static final' on field 'COMPONENT_CONTEXT': the field is declared in an interface type 3 32
UnnecessaryModifier Unnecessary modifiers 'public static final' on field 'COMPONENT_SCOPE': the field is declared in an interface type 3 34
UnnecessaryModifier Unnecessary modifiers 'public static final' on field 'LOCALE_KEY': the field is declared in an interface type 3 35
UnnecessaryModifier Unnecessary modifiers 'public static final' on field 'EXCEPTION_KEY': the field is declared in an interface type 3 36

org/apache/struts/tiles/taglib/DefinitionTag.java

Rule Violation Priority Line
UselessParentheses Useless parentheses. 4 110

org/apache/struts/tiles/taglib/ImportAttributeTag.java

Rule Violation Priority Line
UselessParentheses Useless parentheses. 4 86
CollapsibleIfStatements These nested if statements could be combined 3 195198
UselessParentheses Useless parentheses. 4 215

org/apache/struts/tiles/taglib/InsertTag.java

Rule Violation Priority Line
EmptyCatchBlock Avoid empty catch blocks 3 718720
UnnecessaryModifier Unnecessary modifier 'public' on method 'doStartTag': the method is declared in an interface type 3 774
UnnecessaryModifier Unnecessary modifier 'public' on method 'doEndTag': the method is declared in an interface type 3 778
UnnecessaryModifier Unnecessary modifier 'public' on method 'putAttribute': the method is declared in an interface type 3 782

org/apache/struts/tiles/taglib/PutListTag.java

Rule Violation Priority Line
UselessParentheses Useless parentheses. 4 165

org/apache/struts/tiles/taglib/PutTag.java

Rule Violation Priority Line
UselessParentheses Useless parentheses. 4 456

org/apache/struts/tiles/taglib/UseAttributeTag.java

Rule Violation Priority Line
UselessParentheses Useless parentheses. 4 98
UselessParentheses Useless parentheses. 4 212

org/apache/struts/tiles/xmlDefinition/I18nFactorySet.java

Rule Violation Priority Line
EmptyCatchBlock Avoid empty catch blocks 3 209211
EmptyCatchBlock Avoid empty catch blocks 3 493494
UnconditionalIfStatement Do not use if statements that are always true or always false 3 512