Built by Maven

Checkstyle Results

The following document contains the results of Checkstyle 10.14.0 with struts_checks.xml ruleset.

Summary

Files  Info  Warnings  Errors
8 0 0 66

Files

File  I  W  E
org/apache/struts/scripting/IOUtils.java 0 0 7
org/apache/struts/scripting/RequestToVariableFilter.java 0 0 5
org/apache/struts/scripting/Script.java 0 0 13
org/apache/struts/scripting/ScriptAction.java 0 0 20
org/apache/struts/scripting/ScriptContextFilter.java 0 0 2
org/apache/struts/scripting/StrutsInfo.java 0 0 12
org/apache/struts/scripting/TestFilter.java 0 0 5
org/apache/struts/scripting/package-info.java 0 0 2

Rules

Category Rule Violations Severity
design FinalClass 1  Error
VisibilityModifier
  • protectedAllowed: "true"
 7  Error
header RegexpHeader
  • header
    1: /
    2: *
    3: s*
    4: 
    5: *
    6: s*
    7: $Id.*
    8: $
    9: 
    10: *
    11: s*
    12: 
    13: *
    14: s*Copyright
    15: d{4}(-
    16: d{4}|,
    17: d{4})* The Apache Software Fou
    18: datio
    19: .
    20: 
    21: *
    22: s*
    23: 
    24: *
    25: s*Lice
    26: sed u
    27: der the Apache Lice
    28: se, Versio
    29:  2
    30: .0
    31: (the .Lice
    32: se.
    33: );
    34: 
    35: *
    36: s*you may
    37: ot use this file except i
    38:  complia
    39: ce with the Lice
    40: se
    41: .
    42: 
    43: *
    44: s*You may obtai
    45:  a copy of the Lice
    46: se at
    47: 
    48: *
    49: s*
    50: 
    51: *
    52: s*http://www
    53: .apache
    54: .org/lice
    55: ses/LICENSE
    56: -2
    57: .0
    58: 
    59: *
    60: s*
    61: 
    62: *
    63: s*U
    64: less required by applicable law or agreed to i
    65:  writi
    66: g, software
    67: 
    68: *
    69: s*distributed u
    70: der the Lice
    71: se is distributed o
    72:  a
    73:  .AS IS. BASIS,
    74: 
    75: *
    76: s*WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied
    77: .
    78: 
    79: *
    80: s*See the Lice
    81: se for the specific la
    82: guage gover
    83: i
    84: g permissio
    85: s a
    86: d
    87: 
    88: *
    89: s*limitatio
    90: s u
    91: der the Lice
    92: se
    93: .
    94: 
    95: */
    96: s*
 8  Error
javadoc JavadocStyle 2  Error
misc FinalParameters 33  Error
NewlineAtEndOfFile 8  Error
modifier ModifierOrder 1  Error
RedundantModifier 1  Error
regexp RegexpSingleline
  • format: "\s+$"
  • maximum: "0"
  • message: "Line has trailing spaces."
  • minimum: "0"
 1  Error
whitespace OperatorWrap 1  Error
WhitespaceAfter 1  Error
WhitespaceAround 2  Error

Details

org/apache/struts/scripting/IOUtils.java

Severity Category Rule Message Line
 Error misc NewlineAtEndOfFile File does not end with a newline. 1
 Error header RegexpHeader Line does not match expected header line of '/\*\s*'. 1
 Error design FinalClass Class IOUtils should be declared as final. 18
 Error whitespace WhitespaceAround '{' is not followed by whitespace. 20
 Error whitespace WhitespaceAround '}' is not preceded with whitespace. 20
 Error misc FinalParameters Parameter reader should be final. 53
 Error whitespace WhitespaceAfter 'typecast' is not followed by whitespace. 55

org/apache/struts/scripting/RequestToVariableFilter.java

Severity Category Rule Message Line
 Error misc NewlineAtEndOfFile File does not end with a newline. 1
 Error header RegexpHeader Line does not match expected header line of ' \*\s*Copyright \d{4}(-\d{4}|,\d{4})* The Apache Software Foundation\.'. 4
 Error misc FinalParameters Parameter name should be final. 53
 Error misc FinalParameters Parameter props should be final. 53
 Error misc FinalParameters Parameter context should be final. 62

org/apache/struts/scripting/Script.java

Severity Category Rule Message Line
 Error misc NewlineAtEndOfFile File does not end with a newline. 1
 Error header RegexpHeader Line does not match expected header line of '/\*\s*'. 1
 Error design VisibilityModifier Variable 'name' must be private and have accessor methods. 44
 Error design VisibilityModifier Variable 'path' must be private and have accessor methods. 50
 Error design VisibilityModifier Variable 'scriptEngine' must be private and have accessor methods. 53
 Error javadoc JavadocStyle First sentence should end with a period. 55
 Error design VisibilityModifier Variable 'compilable' must be private and have accessor methods. 56
 Error design VisibilityModifier Variable 'lastModifiedTime' must be private and have accessor methods. 59
 Error design VisibilityModifier Variable 'content' must be private and have accessor methods. 62
 Error design VisibilityModifier Variable 'compiledScript' must be private and have accessor methods. 65
 Error modifier RedundantModifier Redundant 'public' modifier. 83
 Error regexp RegexpSingleline Line has trailing spaces. 103
 Error whitespace OperatorWrap '&&' should be on a new line. 151

org/apache/struts/scripting/ScriptAction.java

Severity Category Rule Message Line
 Error misc NewlineAtEndOfFile File does not end with a newline. 1
 Error header RegexpHeader Line does not match expected header line of ' \*\s*Copyright \d{4}(-\d{4}|,\d{4})* The Apache Software Foundation\.'. 4
 Error modifier ModifierOrder 'static' modifier out of order with the JLS suggestions. 119
 Error javadoc JavadocStyle First sentence should end with a period. 122
 Error misc FinalParameters Parameter mapping should be final. 255
 Error misc FinalParameters Parameter form should be final. 256
 Error misc FinalParameters Parameter request should be final. 257
 Error misc FinalParameters Parameter response should be final. 258
 Error misc FinalParameters Parameter url should be final. 317
 Error misc FinalParameters Parameter params should be final. 317
 Error misc FinalParameters Parameter props should be final. 429
 Error misc FinalParameters Parameter req should be final. 461
 Error misc FinalParameters Parameter req should be final. 471
 Error misc FinalParameters Parameter req should be final. 481
 Error misc FinalParameters Parameter req should be final. 490
 Error misc FinalParameters Parameter req should be final. 500
 Error misc FinalParameters Parameter req should be final. 510
 Error misc FinalParameters Parameter mes should be final. 510
 Error misc FinalParameters Parameter req should be final. 524
 Error misc FinalParameters Parameter errs should be final. 524

org/apache/struts/scripting/ScriptContextFilter.java

Severity Category Rule Message Line
 Error misc NewlineAtEndOfFile File does not end with a newline. 1
 Error header RegexpHeader Line does not match expected header line of ' \*\s*Copyright \d{4}(-\d{4}|,\d{4})* The Apache Software Foundation\.'. 4

org/apache/struts/scripting/StrutsInfo.java

Severity Category Rule Message Line
 Error misc NewlineAtEndOfFile File does not end with a newline. 1
 Error header RegexpHeader Line does not match expected header line of ' \*\s*Copyright \d{4}(-\d{4}|,\d{4})* The Apache Software Foundation\.'. 4
 Error misc FinalParameters Parameter action should be final. 61
 Error misc FinalParameters Parameter mapping should be final. 61
 Error misc FinalParameters Parameter form should be final. 62
 Error misc FinalParameters Parameter res should be final. 62
 Error misc FinalParameters Parameter f should be final. 74
 Error misc FinalParameters Parameter f should be final. 98
 Error misc FinalParameters Parameter form should be final. 107
 Error misc FinalParameters Parameter mapping should be final. 116
 Error misc FinalParameters Parameter action should be final. 125
 Error misc FinalParameters Parameter res should be final. 134

org/apache/struts/scripting/TestFilter.java

Severity Category Rule Message Line
 Error misc NewlineAtEndOfFile File does not end with a newline. 1
 Error header RegexpHeader Line does not match expected header line of ' \*\s*Copyright \d{4}(-\d{4}|,\d{4})* The Apache Software Foundation\.'. 4
 Error misc FinalParameters Parameter name should be final. 48
 Error misc FinalParameters Parameter props should be final. 48
 Error misc FinalParameters Parameter context should be final. 59

org/apache/struts/scripting/package-info.java

Severity Category Rule Message Line
 Error misc NewlineAtEndOfFile File does not end with a newline. 1
 Error header RegexpHeader Line does not match expected header line of ' \*\s*Copyright \d{4}(-\d{4}|,\d{4})* The Apache Software Foundation\.'. 4