Built by Maven

Checkstyle Results

The following document contains the results of Checkstyle 10.14.0 with struts_checks.xml ruleset.

Summary

Files  Info  Warnings  Errors
15 0 0 168

Files

File  I  W  E
org/apache/struts/apps/mailreader/Constants.java 0 0 3
org/apache/struts/apps/mailreader/actions/BaseAction.java 0 0 40
org/apache/struts/apps/mailreader/actions/LocaleAction.java 0 0 9
org/apache/struts/apps/mailreader/actions/LogoffAction.java 0 0 8
org/apache/struts/apps/mailreader/actions/LogonAction.java 0 0 7
org/apache/struts/apps/mailreader/actions/MainMenuAction.java 0 0 7
org/apache/struts/apps/mailreader/actions/RegistrationAction.java 0 0 31
org/apache/struts/apps/mailreader/actions/SubscriptionAction.java 0 0 35
org/apache/struts/apps/mailreader/actions/WelcomeAction.java 0 0 7
org/apache/struts/apps/mailreader/plugin/MemoryDatabasePlugIn.java 0 0 16
org/apache/struts/apps/mailreader/resources/AlternateApplicationResources.properties 0 0 1
org/apache/struts/apps/mailreader/resources/AlternateApplicationResources_ja.properties 0 0 1
org/apache/struts/apps/mailreader/resources/ApplicationResources.properties 0 0 1
org/apache/struts/apps/mailreader/resources/ApplicationResources_ja.properties 0 0 1
org/apache/struts/apps/mailreader/resources/ApplicationResources_ru.properties 0 0 1

Rules

Category Rule Violations Severity
blocks RightCurly 2  Error
coding MagicNumber 3  Error
design HideUtilityClassConstructor 1  Error
VisibilityModifier
  • protectedAllowed: "true"
 4  Error
header RegexpHeader
  • header
    1: /
    2: *
    3: s*
    4: 
    5: *
    6: s*
    7: $Id.*
    8: $
    9: 
    10: *
    11: s*
    12: 
    13: *
    14: s*Copyright
    15: d{4}(-
    16: d{4}|,
    17: d{4})* The Apache Software Fou
    18: datio
    19: .
    20: 
    21: *
    22: s*
    23: 
    24: *
    25: s*Lice
    26: sed u
    27: der the Apache Lice
    28: se, Versio
    29:  2
    30: .0
    31: (the .Lice
    32: se.
    33: );
    34: 
    35: *
    36: s*you may
    37: ot use this file except i
    38:  complia
    39: ce with the Lice
    40: se
    41: .
    42: 
    43: *
    44: s*You may obtai
    45:  a copy of the Lice
    46: se at
    47: 
    48: *
    49: s*
    50: 
    51: *
    52: s*http://www
    53: .apache
    54: .org/lice
    55: ses/LICENSE
    56: -2
    57: .0
    58: 
    59: *
    60: s*
    61: 
    62: *
    63: s*U
    64: less required by applicable law or agreed to i
    65:  writi
    66: g, software
    67: 
    68: *
    69: s*distributed u
    70: der the Lice
    71: se is distributed o
    72:  a
    73:  .AS IS. BASIS,
    74: 
    75: *
    76: s*WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied
    77: .
    78: 
    79: *
    80: s*See the Lice
    81: se for the specific la
    82: guage gover
    83: i
    84: g permissio
    85: s a
    86: d
    87: 
    88: *
    89: s*limitatio
    90: s u
    91: der the Lice
    92: se
    93: .
    94: 
    95: */
    96: s*
 15  Error
javadoc JavadocMethod
  • validateThrows: "true"
 2  Error
JavadocPackage
  • allowLegacy: "true"
 3  Error
JavadocVariable 1  Error
MissingJavadocMethod 5  Error
misc ArrayTypeStyle 1  Error
FinalParameters 96  Error
NewlineAtEndOfFile 9  Error
modifier ModifierOrder 14  Error
naming LocalFinalVariableName 1  Error
MemberName 2  Error
MethodName 5  Error
StaticVariableName 2  Error
whitespace MethodParamPad 1  Error
OperatorWrap 1  Error

Details

org/apache/struts/apps/mailreader/Constants.java

Severity Category Rule Message Line
 Error javadoc JavadocPackage Missing package-info.java file. 1
 Error header RegexpHeader Line does not match expected header line of ' \*\s*Copyright \d{4}(-\d{4}|,\d{4})* The Apache Software Foundation\.'. 4
 Error design HideUtilityClassConstructor Utility classes should not have a public or default constructor. 34

org/apache/struts/apps/mailreader/actions/BaseAction.java

Severity Category Rule Message Line
 Error misc NewlineAtEndOfFile File does not end with a newline. 1
 Error header RegexpHeader Line does not match expected header line of ' \*\s*Copyright \d{4}(-\d{4}|,\d{4})* The Apache Software Foundation\.'. 4
 Error design VisibilityModifier Variable 'USERNAME' must be private and have accessor methods. 67
 Error naming StaticVariableName Name 'USERNAME' must match pattern '^[a-z][a-zA-Z0-9]*$'. 67
 Error design VisibilityModifier Variable 'PASSWORD' must be private and have accessor methods. 74
 Error naming StaticVariableName Name 'PASSWORD' must match pattern '^[a-z][a-zA-Z0-9]*$'. 74
 Error modifier ModifierOrder 'static' modifier out of order with the JLS suggestions. 81
 Error modifier ModifierOrder 'static' modifier out of order with the JLS suggestions. 88
 Error misc FinalParameters Parameter request should be final. 102
 Error misc FinalParameters Parameter user should be final. 102
 Error misc FinalParameters Parameter session should be final. 119
 Error misc FinalParameters Parameter method should be final. 119
 Error misc FinalParameters Parameter key should be final. 119
 Error misc FinalParameters Parameter mapping should be final. 135
 Error misc FinalParameters Parameter mapping should be final. 149
 Error misc FinalParameters Parameter mapping should be final. 164
 Error misc FinalParameters Parameter form should be final. 182
 Error misc FinalParameters Parameter property should be final. 182
 Error misc FinalParameters Parameter session should be final. 207
 Error misc FinalParameters Parameter request should be final. 219
 Error misc FinalParameters Parameter database should be final. 239
 Error misc FinalParameters Parameter username should be final. 239
 Error misc FinalParameters Parameter password should be final. 240
 Error misc FinalParameters Parameter errors should be final. 240
 Error misc FinalParameters Parameter username should be final. 282
 Error misc FinalParameters Parameter password should be final. 283
 Error misc FinalParameters Parameter errors should be final. 283
 Error misc FinalParameters Parameter session should be final. 311
 Error misc FinalParameters Parameter request should be final. 323
 Error misc FinalParameters Parameter mapping should be final. 339
 Error misc FinalParameters Parameter request should be final. 340
 Error misc FinalParameters Parameter errors should be final. 341
 Error misc FinalParameters Parameter mapping should be final. 355
 Error misc FinalParameters Parameter method should be final. 355
 Error misc FinalParameters Parameter request should be final. 366
 Error misc FinalParameters Parameter user should be final. 379
 Error naming LocalFinalVariableName Name 'LOG_DATABASE_SAVE_ERROR' must match pattern '^[a-z][a-zA-Z0-9]*$'. 381
 Error misc FinalParameters Parameter form should be final. 404
 Error misc FinalParameters Parameter property should be final. 404
 Error misc FinalParameters Parameter value should be final. 404

org/apache/struts/apps/mailreader/actions/LocaleAction.java

Severity Category Rule Message Line
 Error misc NewlineAtEndOfFile File does not end with a newline. 1
 Error javadoc JavadocPackage Missing package-info.java file. 1
 Error header RegexpHeader Line does not match expected header line of ' \*\s*Copyright \d{4}(-\d{4}|,\d{4})* The Apache Software Foundation\.'. 4
 Error modifier ModifierOrder 'static' modifier out of order with the JLS suggestions. 48
 Error misc FinalParameters Parameter string should be final. 59
 Error misc FinalParameters Parameter mapping should be final. 118
 Error misc FinalParameters Parameter form should be final. 119
 Error misc FinalParameters Parameter request should be final. 120
 Error misc FinalParameters Parameter response should be final. 121

org/apache/struts/apps/mailreader/actions/LogoffAction.java

Severity Category Rule Message Line
 Error misc NewlineAtEndOfFile File does not end with a newline. 1
 Error header RegexpHeader Line does not match expected header line of ' \*\s*Copyright \d{4}(-\d{4}|,\d{4})* The Apache Software Foundation\.'. 4
 Error modifier ModifierOrder 'static' modifier out of order with the JLS suggestions. 49
 Error javadoc MissingJavadocMethod Missing a Javadoc comment. 53
 Error misc FinalParameters Parameter mapping should be final. 54
 Error misc FinalParameters Parameter form should be final. 55
 Error misc FinalParameters Parameter request should be final. 56
 Error misc FinalParameters Parameter response should be final. 57

org/apache/struts/apps/mailreader/actions/LogonAction.java

Severity Category Rule Message Line
 Error misc NewlineAtEndOfFile File does not end with a newline. 1
 Error header RegexpHeader Line does not match expected header line of ' \*\s*Copyright \d{4}(-\d{4}|,\d{4})* The Apache Software Foundation\.'. 4
 Error javadoc JavadocMethod @return tag should be present and have description. 56
 Error misc FinalParameters Parameter mapping should be final. 57
 Error misc FinalParameters Parameter form should be final. 58
 Error misc FinalParameters Parameter request should be final. 59
 Error misc FinalParameters Parameter response should be final. 60

org/apache/struts/apps/mailreader/actions/MainMenuAction.java

Severity Category Rule Message Line
 Error misc NewlineAtEndOfFile File does not end with a newline. 1
 Error header RegexpHeader Line does not match expected header line of ' \*\s*\$Id.*\$'. 2
 Error javadoc MissingJavadocMethod Missing a Javadoc comment. 36
 Error misc FinalParameters Parameter mapping should be final. 37
 Error misc FinalParameters Parameter form should be final. 38
 Error misc FinalParameters Parameter request should be final. 39
 Error misc FinalParameters Parameter response should be final. 40

org/apache/struts/apps/mailreader/actions/RegistrationAction.java

Severity Category Rule Message Line
 Error misc NewlineAtEndOfFile File does not end with a newline. 1
 Error header RegexpHeader Line does not match expected header line of ' \*\s*\$Id.*\$'. 2
 Error modifier ModifierOrder 'static' modifier out of order with the JLS suggestions. 58
 Error modifier ModifierOrder 'static' modifier out of order with the JLS suggestions. 68
 Error modifier ModifierOrder 'static' modifier out of order with the JLS suggestions. 75
 Error modifier ModifierOrder 'static' modifier out of order with the JLS suggestions. 82
 Error modifier ModifierOrder 'static' modifier out of order with the JLS suggestions. 89
 Error design VisibilityModifier Variable 'LOG_REGISTRATION_POPULATE' must be private and have accessor methods. 98
 Error naming MemberName Name 'LOG_REGISTRATION_POPULATE' must match pattern '^[a-z][a-zA-Z0-9]*$'. 98
 Error misc FinalParameters Parameter username should be final. 108
 Error misc FinalParameters Parameter errors should be final. 109
 Error misc FinalParameters Parameter form should be final. 129
 Error misc FinalParameters Parameter request should be final. 130
 Error misc FinalParameters Parameter errors should be final. 131
 Error blocks RightCurly '}' at column 9 should be on the same line as the next part of a multi-block statement (one that directly contains multiple blocks: if/else-if/else, do/while or try/catch/finally). 141
 Error misc FinalParameters Parameter form should be final. 183
 Error misc FinalParameters Parameter user should be final. 183
 Error misc FinalParameters Parameter user should be final. 218
 Error misc FinalParameters Parameter form should be final. 218
 Error misc FinalParameters Parameter request should be final. 257
 Error misc FinalParameters Parameter errors should be final. 258
 Error naming MethodName Name 'Edit' must match pattern '^[a-z][a-zA-Z0-9]*$'. 286
 Error misc FinalParameters Parameter mapping should be final. 287
 Error misc FinalParameters Parameter form should be final. 288
 Error misc FinalParameters Parameter request should be final. 289
 Error misc FinalParameters Parameter response should be final. 290
 Error naming MethodName Name 'Save' must match pattern '^[a-z][a-zA-Z0-9]*$'. 323
 Error misc FinalParameters Parameter mapping should be final. 324
 Error misc FinalParameters Parameter form should be final. 325
 Error misc FinalParameters Parameter request should be final. 326
 Error misc FinalParameters Parameter response should be final. 327

org/apache/struts/apps/mailreader/actions/SubscriptionAction.java

Severity Category Rule Message Line
 Error misc NewlineAtEndOfFile File does not end with a newline. 1
 Error header RegexpHeader Line does not match expected header line of ' \*\s*\$Id.*\$'. 2
 Error modifier ModifierOrder 'static' modifier out of order with the JLS suggestions. 48
 Error modifier ModifierOrder 'static' modifier out of order with the JLS suggestions. 58
 Error modifier ModifierOrder 'static' modifier out of order with the JLS suggestions. 65
 Error modifier ModifierOrder 'static' modifier out of order with the JLS suggestions. 72
 Error javadoc JavadocVariable Missing a Javadoc comment. 76
 Error design VisibilityModifier Variable 'LOG_SUBSCRIPTION_POPULATE' must be private and have accessor methods. 76
 Error naming MemberName Name 'LOG_SUBSCRIPTION_POPULATE' must match pattern '^[a-z][a-zA-Z0-9]*$'. 76
 Error misc FinalParameters Parameter user should be final. 88
 Error misc FinalParameters Parameter host should be final. 88
 Error blocks RightCurly '}' at column 9 should be on the same line as the next part of a multi-block statement (one that directly contains multiple blocks: if/else-if/else, do/while or try/catch/finally). 94
 Error misc FinalParameters Parameter subscription should be final. 116
 Error misc FinalParameters Parameter form should be final. 116
 Error misc FinalParameters Parameter form should be final. 145
 Error misc FinalParameters Parameter subscription should be final. 145
 Error misc FinalParameters Parameter mapping should be final. 182
 Error misc FinalParameters Parameter session should be final. 183
 Error misc FinalParameters Parameter user should be final. 184
 Error misc FinalParameters Parameter subscription should be final. 185
 Error naming MethodName Name 'Delete' must match pattern '^[a-z][a-zA-Z0-9]*$'. 221
 Error misc FinalParameters Parameter mapping should be final. 222
 Error misc FinalParameters Parameter form should be final. 223
 Error misc FinalParameters Parameter request should be final. 224
 Error misc FinalParameters Parameter response should be final. 225
 Error naming MethodName Name 'Edit' must match pattern '^[a-z][a-zA-Z0-9]*$'. 254
 Error misc FinalParameters Parameter mapping should be final. 255
 Error misc FinalParameters Parameter form should be final. 256
 Error misc FinalParameters Parameter request should be final. 257
 Error misc FinalParameters Parameter response should be final. 258
 Error naming MethodName Name 'Save' must match pattern '^[a-z][a-zA-Z0-9]*$'. 299
 Error misc FinalParameters Parameter mapping should be final. 300
 Error misc FinalParameters Parameter form should be final. 301
 Error misc FinalParameters Parameter request should be final. 302
 Error misc FinalParameters Parameter response should be final. 303

org/apache/struts/apps/mailreader/actions/WelcomeAction.java

Severity Category Rule Message Line
 Error misc NewlineAtEndOfFile File does not end with a newline. 1
 Error header RegexpHeader Line does not match expected header line of ' \*\s*Copyright \d{4}(-\d{4}|,\d{4})* The Apache Software Foundation\.'. 4
 Error javadoc MissingJavadocMethod Missing a Javadoc comment. 56
 Error misc FinalParameters Parameter mapping should be final. 57
 Error misc FinalParameters Parameter form should be final. 58
 Error misc FinalParameters Parameter request should be final. 59
 Error misc FinalParameters Parameter response should be final. 60

org/apache/struts/apps/mailreader/plugin/MemoryDatabasePlugIn.java

Severity Category Rule Message Line
 Error misc NewlineAtEndOfFile File does not end with a newline. 1
 Error javadoc JavadocPackage Missing package-info.java file. 1
 Error header RegexpHeader Line does not match expected header line of ' \*\s*Copyright \d{4}(-\d{4}|,\d{4})* The Apache Software Foundation\.'. 4
 Error modifier ModifierOrder 'static' modifier out of order with the JLS suggestions. 74
 Error javadoc MissingJavadocMethod Missing a Javadoc comment. 93
 Error javadoc MissingJavadocMethod Missing a Javadoc comment. 97
 Error misc FinalParameters Parameter pathname should be final. 97
 Error misc FinalParameters Parameter servlet should be final. 136
 Error misc FinalParameters Parameter config should be final. 136
 Error whitespace OperatorWrap '+' should be on a new line. 154
 Error javadoc JavadocMethod @return tag should be present and have description. 179
 Error whitespace MethodParamPad '(' should be on the previous line. 190
 Error coding MagicNumber '1024' is a magic number. 198
 Error coding MagicNumber '1024' is a magic number. 199
 Error misc ArrayTypeStyle Array brackets at illegal position. 201
 Error coding MagicNumber '1024' is a magic number. 201

org/apache/struts/apps/mailreader/resources/AlternateApplicationResources.properties

Severity Category Rule Message Line
 Error header RegexpHeader Line does not match expected header line of '/\*\s*'. 1

org/apache/struts/apps/mailreader/resources/AlternateApplicationResources_ja.properties

Severity Category Rule Message Line
 Error header RegexpHeader Missing a header - not enough lines in file. 1

org/apache/struts/apps/mailreader/resources/ApplicationResources.properties

Severity Category Rule Message Line
 Error header RegexpHeader Line does not match expected header line of '/\*\s*'. 1

org/apache/struts/apps/mailreader/resources/ApplicationResources_ja.properties

Severity Category Rule Message Line
 Error header RegexpHeader Line does not match expected header line of '/\*\s*'. 1

org/apache/struts/apps/mailreader/resources/ApplicationResources_ru.properties

Severity Category Rule Message Line
 Error header RegexpHeader Line does not match expected header line of '/\*\s*'. 1