Built by Maven

Checkstyle Results

The following document contains the results of Checkstyle 10.14.0 with struts_checks.xml ruleset.

Summary

Files  Info  Warnings  Errors
9 0 0 167

Files

File  I  W  E
org/apache/struts/apps/mailreader/dao/ExpiredPasswordException.java 0 0 2
org/apache/struts/apps/mailreader/dao/Subscription.java 0 0 17
org/apache/struts/apps/mailreader/dao/User.java 0 0 24
org/apache/struts/apps/mailreader/dao/UserDatabase.java 0 0 14
org/apache/struts/apps/mailreader/dao/impl/AbstractSubscription.java 0 0 27
org/apache/struts/apps/mailreader/dao/impl/AbstractUser.java 0 0 33
org/apache/struts/apps/mailreader/dao/impl/memory/MemorySubscription.java 0 0 6
org/apache/struts/apps/mailreader/dao/impl/memory/MemoryUser.java 0 0 5
org/apache/struts/apps/mailreader/dao/impl/memory/MemoryUserDatabase.java 0 0 39

Rules

Category Rule Violations Severity
design DesignForExtension 16  Error
header RegexpHeader
  • header
    1: /
    2: *
    3: s*
    4: 
    5: *
    6: s*
    7: $Id.*
    8: $
    9: 
    10: *
    11: s*
    12: 
    13: *
    14: s*Copyright
    15: d{4}(-
    16: d{4}|,
    17: d{4})* The Apache Software Fou
    18: datio
    19: .
    20: 
    21: *
    22: s*
    23: 
    24: *
    25: s*Lice
    26: sed u
    27: der the Apache Lice
    28: se, Versio
    29:  2
    30: .0
    31: (the .Lice
    32: se.
    33: );
    34: 
    35: *
    36: s*you may
    37: ot use this file except i
    38:  complia
    39: ce with the Lice
    40: se
    41: .
    42: 
    43: *
    44: s*You may obtai
    45:  a copy of the Lice
    46: se at
    47: 
    48: *
    49: s*
    50: 
    51: *
    52: s*http://www
    53: .apache
    54: .org/lice
    55: ses/LICENSE
    56: -2
    57: .0
    58: 
    59: *
    60: s*
    61: 
    62: *
    63: s*U
    64: less required by applicable law or agreed to i
    65:  writi
    66: g, software
    67: 
    68: *
    69: s*distributed u
    70: der the Lice
    71: se is distributed o
    72:  a
    73:  .AS IS. BASIS,
    74: 
    75: *
    76: s*WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied
    77: .
    78: 
    79: *
    80: s*See the Lice
    81: se for the specific la
    82: guage gover
    83: i
    84: g permissio
    85: s a
    86: d
    87: 
    88: *
    89: s*limitatio
    90: s u
    91: der the Lice
    92: se
    93: .
    94: 
    95: */
    96: s*
 9  Error
imports UnusedImports
  • processJavadoc: "false"
 1  Error
javadoc JavadocMethod
  • validateThrows: "true"
 28  Error
JavadocPackage
  • allowLegacy: "true"
 3  Error
JavadocVariable 6  Error
MissingJavadocMethod 26  Error
misc ArrayTypeStyle 2  Error
FinalParameters 29  Error
NewlineAtEndOfFile 1  Error
modifier ModifierOrder 1  Error
RedundantModifier 33  Error
whitespace MethodParamPad 7  Error
OperatorWrap 3  Error
WhitespaceAround 2  Error

Details

org/apache/struts/apps/mailreader/dao/ExpiredPasswordException.java

Severity Category Rule Message Line
 Error header RegexpHeader Line does not match expected header line of ' \*\s*Copyright \d{4}(-\d{4}|,\d{4})* The Apache Software Foundation\.'. 4
 Error misc FinalParameters Parameter username should be final. 43

org/apache/struts/apps/mailreader/dao/Subscription.java

Severity Category Rule Message Line
 Error header RegexpHeader Line does not match expected header line of ' \*\s*Copyright \d{4}(-\d{4}|,\d{4})* The Apache Software Foundation\.'. 4
 Error javadoc JavadocMethod @return tag should be present and have description. 43
 Error modifier RedundantModifier Redundant 'public' modifier. 43
 Error modifier RedundantModifier Redundant 'public' modifier. 51
 Error javadoc JavadocMethod @return tag should be present and have description. 57
 Error modifier RedundantModifier Redundant 'public' modifier. 57
 Error javadoc JavadocMethod @return tag should be present and have description. 63
 Error modifier RedundantModifier Redundant 'public' modifier. 63
 Error modifier RedundantModifier Redundant 'public' modifier. 71
 Error javadoc JavadocMethod @return tag should be present and have description. 77
 Error modifier RedundantModifier Redundant 'public' modifier. 77
 Error modifier RedundantModifier Redundant 'public' modifier. 85
 Error javadoc JavadocMethod @return tag should be present and have description. 91
 Error modifier RedundantModifier Redundant 'public' modifier. 91
 Error javadoc JavadocMethod @return tag should be present and have description. 97
 Error modifier RedundantModifier Redundant 'public' modifier. 97
 Error modifier RedundantModifier Redundant 'public' modifier. 105

org/apache/struts/apps/mailreader/dao/User.java

Severity Category Rule Message Line
 Error header RegexpHeader Line does not match expected header line of ' \*\s*Copyright \d{4}(-\d{4}|,\d{4})* The Apache Software Foundation\.'. 4
 Error javadoc JavadocMethod @return tag should be present and have description. 44
 Error modifier RedundantModifier Redundant 'public' modifier. 44
 Error javadoc JavadocMethod @return tag should be present and have description. 50
 Error modifier RedundantModifier Redundant 'public' modifier. 50
 Error modifier RedundantModifier Redundant 'public' modifier. 58
 Error javadoc JavadocMethod @return tag should be present and have description. 64
 Error modifier RedundantModifier Redundant 'public' modifier. 64
 Error modifier RedundantModifier Redundant 'public' modifier. 72
 Error javadoc JavadocMethod @return tag should be present and have description. 78
 Error modifier RedundantModifier Redundant 'public' modifier. 78
 Error modifier RedundantModifier Redundant 'public' modifier. 86
 Error javadoc JavadocMethod @return tag should be present and have description. 92
 Error modifier RedundantModifier Redundant 'public' modifier. 92
 Error modifier RedundantModifier Redundant 'public' modifier. 100
 Error javadoc JavadocMethod @return tag should be present and have description. 107
 Error modifier RedundantModifier Redundant 'public' modifier. 107
 Error javadoc JavadocMethod @return tag should be present and have description. 113
 Error modifier RedundantModifier Redundant 'public' modifier. 113
 Error javadoc JavadocMethod @return tag should be present and have description. 128
 Error modifier RedundantModifier Redundant 'public' modifier. 128
 Error javadoc JavadocMethod @return tag should be present and have description. 137
 Error modifier RedundantModifier Redundant 'public' modifier. 137
 Error modifier RedundantModifier Redundant 'public' modifier. 149

org/apache/struts/apps/mailreader/dao/UserDatabase.java

Severity Category Rule Message Line
 Error javadoc JavadocPackage Missing package-info.java file. 1
 Error header RegexpHeader Line does not match expected header line of ' \*\s*Copyright \d{4}(-\d{4}|,\d{4})* The Apache Software Foundation\.'. 4
 Error javadoc JavadocMethod @return tag should be present and have description. 53
 Error modifier RedundantModifier Redundant 'public' modifier. 53
 Error modifier RedundantModifier Redundant 'public' modifier. 61
 Error javadoc JavadocMethod @return tag should be present and have description. 72
 Error modifier RedundantModifier Redundant 'public' modifier. 72
 Error javadoc JavadocMethod @return tag should be present and have description. 78
 Error modifier RedundantModifier Redundant 'public' modifier. 78
 Error javadoc JavadocMethod @return tag should be present and have description. 86
 Error modifier RedundantModifier Redundant 'public' modifier. 86
 Error modifier RedundantModifier Redundant 'public' modifier. 94
 Error modifier RedundantModifier Redundant 'public' modifier. 105
 Error modifier RedundantModifier Redundant 'public' modifier. 113

org/apache/struts/apps/mailreader/dao/impl/AbstractSubscription.java

Severity Category Rule Message Line
 Error javadoc JavadocPackage Missing package-info.java file. 1
 Error header RegexpHeader Line does not match expected header line of ' \*\s*Copyright \d{4}(-\d{4}|,\d{4})* The Apache Software Foundation\.'. 4
 Error misc FinalParameters Parameter user should be final. 49
 Error misc FinalParameters Parameter host should be final. 49
 Error design DesignForExtension Class 'AbstractSubscription' looks like designed for extension (can be subclassed), but the method 'getAutoConnect' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'AbstractSubscription' final or making the method 'getAutoConnect' static/final/abstract/empty, or adding allowed annotation for the method. 81
 Error javadoc MissingJavadocMethod Missing a Javadoc comment. 81
 Error design DesignForExtension Class 'AbstractSubscription' looks like designed for extension (can be subclassed), but the method 'setAutoConnect' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'AbstractSubscription' final or making the method 'setAutoConnect' static/final/abstract/empty, or adding allowed annotation for the method. 85
 Error javadoc MissingJavadocMethod Missing a Javadoc comment. 85
 Error misc FinalParameters Parameter autoConnect should be final. 85
 Error javadoc JavadocMethod @return tag should be present and have description. 93
 Error design DesignForExtension Class 'AbstractSubscription' looks like designed for extension (can be subclassed), but the method 'getPassword' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'AbstractSubscription' final or making the method 'getPassword' static/final/abstract/empty, or adding allowed annotation for the method. 103
 Error javadoc MissingJavadocMethod Missing a Javadoc comment. 103
 Error design DesignForExtension Class 'AbstractSubscription' looks like designed for extension (can be subclassed), but the method 'setPassword' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'AbstractSubscription' final or making the method 'setPassword' static/final/abstract/empty, or adding allowed annotation for the method. 107
 Error javadoc MissingJavadocMethod Missing a Javadoc comment. 107
 Error misc FinalParameters Parameter password should be final. 107
 Error design DesignForExtension Class 'AbstractSubscription' looks like designed for extension (can be subclassed), but the method 'getType' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'AbstractSubscription' final or making the method 'getType' static/final/abstract/empty, or adding allowed annotation for the method. 117
 Error javadoc MissingJavadocMethod Missing a Javadoc comment. 117
 Error design DesignForExtension Class 'AbstractSubscription' looks like designed for extension (can be subclassed), but the method 'setType' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'AbstractSubscription' final or making the method 'setType' static/final/abstract/empty, or adding allowed annotation for the method. 121
 Error javadoc MissingJavadocMethod Missing a Javadoc comment. 121
 Error misc FinalParameters Parameter type should be final. 121
 Error javadoc JavadocMethod @return tag should be present and have description. 129
 Error design DesignForExtension Class 'AbstractSubscription' looks like designed for extension (can be subclassed), but the method 'getUsername' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'AbstractSubscription' final or making the method 'getUsername' static/final/abstract/empty, or adding allowed annotation for the method. 139
 Error javadoc MissingJavadocMethod Missing a Javadoc comment. 139
 Error design DesignForExtension Class 'AbstractSubscription' looks like designed for extension (can be subclassed), but the method 'setUsername' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'AbstractSubscription' final or making the method 'setUsername' static/final/abstract/empty, or adding allowed annotation for the method. 143
 Error javadoc MissingJavadocMethod Missing a Javadoc comment. 143
 Error misc FinalParameters Parameter username should be final. 143
 Error javadoc JavadocMethod @return tag should be present and have description. 154

org/apache/struts/apps/mailreader/dao/impl/AbstractUser.java

Severity Category Rule Message Line
 Error header RegexpHeader Line does not match expected header line of ' \*\s*Copyright \d{4}(-\d{4}|,\d{4})* The Apache Software Foundation\.'. 4
 Error misc FinalParameters Parameter database should be final. 54
 Error misc FinalParameters Parameter username should be final. 54
 Error javadoc JavadocMethod @return tag should be present and have description. 90
 Error design DesignForExtension Class 'AbstractUser' looks like designed for extension (can be subclassed), but the method 'getFromAddress' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'AbstractUser' final or making the method 'getFromAddress' static/final/abstract/empty, or adding allowed annotation for the method. 100
 Error javadoc MissingJavadocMethod Missing a Javadoc comment. 100
 Error design DesignForExtension Class 'AbstractUser' looks like designed for extension (can be subclassed), but the method 'setFromAddress' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'AbstractUser' final or making the method 'setFromAddress' static/final/abstract/empty, or adding allowed annotation for the method. 104
 Error javadoc MissingJavadocMethod Missing a Javadoc comment. 104
 Error misc FinalParameters Parameter fromAddress should be final. 104
 Error design DesignForExtension Class 'AbstractUser' looks like designed for extension (can be subclassed), but the method 'getFullName' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'AbstractUser' final or making the method 'getFullName' static/final/abstract/empty, or adding allowed annotation for the method. 114
 Error javadoc MissingJavadocMethod Missing a Javadoc comment. 114
 Error design DesignForExtension Class 'AbstractUser' looks like designed for extension (can be subclassed), but the method 'setFullName' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'AbstractUser' final or making the method 'setFullName' static/final/abstract/empty, or adding allowed annotation for the method. 118
 Error javadoc MissingJavadocMethod Missing a Javadoc comment. 118
 Error misc FinalParameters Parameter fullName should be final. 118
 Error design DesignForExtension Class 'AbstractUser' looks like designed for extension (can be subclassed), but the method 'getPassword' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'AbstractUser' final or making the method 'getPassword' static/final/abstract/empty, or adding allowed annotation for the method. 128
 Error javadoc MissingJavadocMethod Missing a Javadoc comment. 128
 Error design DesignForExtension Class 'AbstractUser' looks like designed for extension (can be subclassed), but the method 'setPassword' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'AbstractUser' final or making the method 'setPassword' static/final/abstract/empty, or adding allowed annotation for the method. 132
 Error javadoc MissingJavadocMethod Missing a Javadoc comment. 132
 Error misc FinalParameters Parameter password should be final. 132
 Error design DesignForExtension Class 'AbstractUser' looks like designed for extension (can be subclassed), but the method 'getReplyToAddress' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'AbstractUser' final or making the method 'getReplyToAddress' static/final/abstract/empty, or adding allowed annotation for the method. 142
 Error javadoc MissingJavadocMethod Missing a Javadoc comment. 142
 Error design DesignForExtension Class 'AbstractUser' looks like designed for extension (can be subclassed), but the method 'setReplyToAddress' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'AbstractUser' final or making the method 'setReplyToAddress' static/final/abstract/empty, or adding allowed annotation for the method. 146
 Error javadoc MissingJavadocMethod Missing a Javadoc comment. 146
 Error misc FinalParameters Parameter replyToAddress should be final. 146
 Error javadoc JavadocMethod @return tag should be present and have description. 155
 Error javadoc JavadocMethod @return tag should be present and have description. 167
 Error javadoc JavadocMethod @return tag should be present and have description. 184
 Error misc FinalParameters Parameter host should be final. 184
 Error whitespace OperatorWrap '+' should be on a new line. 189
 Error javadoc JavadocMethod @return tag should be present and have description. 209
 Error misc FinalParameters Parameter host should be final. 209
 Error misc FinalParameters Parameter subscription should be final. 227
 Error whitespace MethodParamPad '(' should be on the previous line. 231

org/apache/struts/apps/mailreader/dao/impl/memory/MemorySubscription.java

Severity Category Rule Message Line
 Error javadoc JavadocPackage Missing package-info.java file. 1
 Error header RegexpHeader Line does not match expected header line of ' \*\s*Copyright \d{4}(-\d{4}|,\d{4})* The Apache Software Foundation\.'. 4
 Error imports UnusedImports Unused import - org.apache.struts.apps.mailreader.dao.Subscription. 26
 Error whitespace WhitespaceAround '{' is not preceded with whitespace. 39
 Error misc FinalParameters Parameter user should be final. 52
 Error misc FinalParameters Parameter host should be final. 52

org/apache/struts/apps/mailreader/dao/impl/memory/MemoryUser.java

Severity Category Rule Message Line
 Error header RegexpHeader Line does not match expected header line of ' \*\s*Copyright \d{4}(-\d{4}|,\d{4})* The Apache Software Foundation\.'. 4
 Error whitespace WhitespaceAround '{' is not preceded with whitespace. 39
 Error misc FinalParameters Parameter database should be final. 52
 Error misc FinalParameters Parameter username should be final. 52
 Error javadoc JavadocMethod @return tag should be present and have description. 62

org/apache/struts/apps/mailreader/dao/impl/memory/MemoryUserDatabase.java

Severity Category Rule Message Line
 Error misc NewlineAtEndOfFile File does not end with a newline. 1
 Error header RegexpHeader Line does not match expected header line of ' \*\s*Copyright \d{4}(-\d{4}|,\d{4})* The Apache Software Foundation\.'. 4
 Error modifier ModifierOrder 'static' modifier out of order with the JLS suggestions. 64
 Error javadoc JavadocVariable Missing a Javadoc comment. 73
 Error javadoc JavadocVariable Missing a Javadoc comment. 85
 Error javadoc JavadocVariable Missing a Javadoc comment. 87
 Error javadoc MissingJavadocMethod Missing a Javadoc comment. 89
 Error javadoc MissingJavadocMethod Missing a Javadoc comment. 93
 Error misc FinalParameters Parameter pathname should be final. 93
 Error javadoc MissingJavadocMethod Missing a Javadoc comment. 104
 Error javadoc MissingJavadocMethod Missing a Javadoc comment. 113
 Error misc FinalParameters Parameter username should be final. 113
 Error whitespace OperatorWrap '+' should be on a new line. 117
 Error javadoc MissingJavadocMethod Missing a Javadoc comment. 132
 Error misc FinalParameters Parameter username should be final. 132
 Error javadoc MissingJavadocMethod Missing a Javadoc comment. 142
 Error javadoc MissingJavadocMethod Missing a Javadoc comment. 152
 Error whitespace MethodParamPad '(' should be on the previous line. 163
 Error whitespace MethodParamPad '(' should be on the previous line. 166
 Error javadoc MissingJavadocMethod Missing a Javadoc comment. 184
 Error misc FinalParameters Parameter user should be final. 184
 Error whitespace MethodParamPad '(' should be on the previous line. 188
 Error javadoc MissingJavadocMethod Missing a Javadoc comment. 199
 Error misc ArrayTypeStyle Array brackets at illegal position. 214
 Error misc ArrayTypeStyle Array brackets at illegal position. 218
 Error whitespace MethodParamPad '(' should be on the previous line. 236
 Error whitespace MethodParamPad '(' should be on the previous line. 260
 Error whitespace MethodParamPad '(' should be on the previous line. 268
 Error javadoc MissingJavadocMethod Missing a Javadoc comment. 274
 Error javadoc JavadocVariable Missing a Javadoc comment. 287
 Error misc FinalParameters Parameter digester should be final. 293
 Error misc FinalParameters Parameter attributes should be final. 297
 Error whitespace OperatorWrap '||' should be on a new line. 305
 Error modifier RedundantModifier Redundant 'public' modifier. 326
 Error misc FinalParameters Parameter database should be final. 326
 Error javadoc JavadocVariable Missing a Javadoc comment. 330
 Error javadoc JavadocVariable Missing a Javadoc comment. 332
 Error misc FinalParameters Parameter digester should be final. 338
 Error misc FinalParameters Parameter attributes should be final. 342