Checkstyle Results
The following document contains the results of Checkstyle 10.14.0 with struts_checks.xml ruleset.
Summary
| Files | |||
|---|---|---|---|
| 31 | 0 | 0 | 245 |
Files
Rules
| Category | Rule | Violations | Severity |
|---|---|---|---|
| coding | MagicNumber | 14 | |
| design | HideUtilityClassConstructor | 1 | |
| header | RegexpHeader
|
31 | |
| javadoc | JavadocMethod
|
7 | |
JavadocPackage
|
11 | ||
| JavadocStyle | 50 | ||
| misc | FinalParameters | 106 | |
| NewlineAtEndOfFile | 25 |
Details
examples/MessageResources.properties
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| misc | NewlineAtEndOfFile | File does not end with a newline. | 1 | |
| header | RegexpHeader | Line does not match expected header line of '/\*\s*'. | 1 |
examples/MessageResources_de.properties
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| misc | NewlineAtEndOfFile | File does not end with a newline. | 1 | |
| header | RegexpHeader | Line does not match expected header line of '/\*\s*'. | 1 |
examples/MessageResources_en_CA.properties
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| misc | NewlineAtEndOfFile | File does not end with a newline. | 1 | |
| header | RegexpHeader | Missing a header - not enough lines in file. | 1 |
examples/MessageResources_en_GB.properties
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| misc | NewlineAtEndOfFile | File does not end with a newline. | 1 | |
| header | RegexpHeader | Missing a header - not enough lines in file. | 1 |
examples/MessageResources_en_US.properties
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| misc | NewlineAtEndOfFile | File does not end with a newline. | 1 | |
| header | RegexpHeader | Missing a header - not enough lines in file. | 1 |
examples/MessageResources_es.properties
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| misc | NewlineAtEndOfFile | File does not end with a newline. | 1 | |
| header | RegexpHeader | Line does not match expected header line of '/\*\s*'. | 1 |
examples/MessageResources_fr.properties
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| misc | NewlineAtEndOfFile | File does not end with a newline. | 1 | |
| header | RegexpHeader | Line does not match expected header line of '/\*\s*'. | 1 |
examples/MessageResources_it.properties
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| misc | NewlineAtEndOfFile | File does not end with a newline. | 1 | |
| header | RegexpHeader | Line does not match expected header line of '/\*\s*'. | 1 |
examples/MessageResources_pt.properties
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| misc | NewlineAtEndOfFile | File does not end with a newline. | 1 | |
| header | RegexpHeader | Line does not match expected header line of '/\*\s*'. | 1 |
examples/SuccessAction.java
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| misc | NewlineAtEndOfFile | File does not end with a newline. | 1 | |
| javadoc | JavadocPackage | Missing package-info.java file. | 1 | |
| header | RegexpHeader | Line does not match expected header line of ' \*\s*Copyright \d{4}(-\d{4}|,\d{4})* The Apache Software Foundation\.'. | 4 | |
| misc | FinalParameters | Parameter mapping should be final. | 91 | |
| misc | FinalParameters | Parameter form should be final. | 92 | |
| misc | FinalParameters | Parameter request should be final. | 93 | |
| misc | FinalParameters | Parameter response should be final. | 94 |
examples/TestBean.java
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| header | RegexpHeader | Line does not match expected header line of ' \*\s*Copyright \d{4}(-\d{4}|,\d{4})* The Apache Software Foundation\.'. | 4 | |
| javadoc | JavadocStyle | First sentence should end with a period. | 27 | |
| javadoc | JavadocStyle | First sentence should end with a period. | 37 | |
| javadoc | JavadocStyle | First sentence should end with a period. | 40 | |
| coding | MagicNumber | '45213.451' is a magic number. | 41 | |
| javadoc | JavadocStyle | First sentence should end with a period. | 43 | |
| coding | MagicNumber | '-123.582F' is a magic number. | 44 | |
| javadoc | JavadocStyle | First sentence should end with a period. | 46 | |
| coding | MagicNumber | '256' is a magic number. | 47 | |
| javadoc | JavadocStyle | First sentence should end with a period. | 49 | |
| coding | MagicNumber | '1321546L' is a magic number. | 50 | |
| javadoc | JavadocStyle | First sentence should end with a period. | 52 | |
| coding | MagicNumber | '257' is a magic number. | 53 | |
| javadoc | JavadocStyle | First sentence should end with a period. | 55 | |
| javadoc | JavadocStyle | First sentence should end with a period. | 58 | |
| misc | FinalParameters | Parameter booleanValue should be final. | 132 | |
| misc | FinalParameters | Parameter doubleValue should be final. | 140 | |
| misc | FinalParameters | Parameter floatValue should be final. | 148 | |
| misc | FinalParameters | Parameter intValue should be final. | 156 | |
| misc | FinalParameters | Parameter longValue should be final. | 164 | |
| misc | FinalParameters | Parameter shortValue should be final. | 172 | |
| misc | FinalParameters | Parameter stringValue should be final. | 180 | |
| misc | FinalParameters | Parameter date should be final. | 196 |
examples/bean/ExampleBean.java
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| misc | NewlineAtEndOfFile | File does not end with a newline. | 1 | |
| javadoc | JavadocPackage | Missing package-info.java file. | 1 | |
| header | RegexpHeader | Line does not match expected header line of ' \*\s*Copyright \d{4}(-\d{4}|,\d{4})* The Apache Software Foundation\.'. | 4 | |
| javadoc | JavadocStyle | First sentence should end with a period. | 28 | |
| javadoc | JavadocStyle | First sentence should end with a period. | 38 | |
| javadoc | JavadocStyle | First sentence should end with a period. | 41 | |
| coding | MagicNumber | '45213.451' is a magic number. | 42 | |
| javadoc | JavadocStyle | First sentence should end with a period. | 44 | |
| coding | MagicNumber | '-123.582F' is a magic number. | 45 | |
| javadoc | JavadocStyle | First sentence should end with a period. | 47 | |
| coding | MagicNumber | '256' is a magic number. | 48 | |
| javadoc | JavadocStyle | First sentence should end with a period. | 50 | |
| coding | MagicNumber | '1321546L' is a magic number. | 51 | |
| javadoc | JavadocStyle | First sentence should end with a period. | 53 | |
| coding | MagicNumber | '257' is a magic number. | 54 | |
| javadoc | JavadocStyle | First sentence should end with a period. | 56 | |
| javadoc | JavadocStyle | First sentence should end with a period. | 59 | |
| javadoc | JavadocStyle | First sentence should end with a period. | 62 | |
| javadoc | JavadocStyle | First sentence should end with a period. | 65 | |
| javadoc | JavadocStyle | First sentence should end with a period. | 68 | |
| javadoc | JavadocStyle | First sentence should end with a period. | 71 | |
| misc | FinalParameters | Parameter booleanValue should be final. | 148 | |
| misc | FinalParameters | Parameter doubleValue should be final. | 156 | |
| misc | FinalParameters | Parameter floatValue should be final. | 164 | |
| misc | FinalParameters | Parameter intValue should be final. | 172 | |
| misc | FinalParameters | Parameter longValue should be final. | 180 | |
| misc | FinalParameters | Parameter shortValue should be final. | 188 | |
| misc | FinalParameters | Parameter stringValue should be final. | 196 | |
| misc | FinalParameters | Parameter list should be final. | 212 | |
| misc | FinalParameters | Parameter nested should be final. | 228 | |
| misc | FinalParameters | Parameter date should be final. | 244 | |
| misc | FinalParameters | Parameter array should be final. | 260 | |
| misc | FinalParameters | Parameter html should be final. | 276 |
examples/bean/NestedBean.java
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| header | RegexpHeader | Line does not match expected header line of ' \*\s*Copyright \d{4}(-\d{4}|,\d{4})* The Apache Software Foundation\.'. | 4 | |
| javadoc | JavadocStyle | First sentence should end with a period. | 27 | |
| javadoc | JavadocStyle | First sentence should end with a period. | 37 | |
| misc | FinalParameters | Parameter stringValue should be final. | 64 |
examples/bean/PrepareBeanAction.java
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| misc | NewlineAtEndOfFile | File does not end with a newline. | 1 | |
| header | RegexpHeader | Line does not match expected header line of ' \*\s*Copyright \d{4}(-\d{4}|,\d{4})* The Apache Software Foundation\.'. | 4 | |
| misc | FinalParameters | Parameter mapping should be final. | 67 | |
| misc | FinalParameters | Parameter form should be final. | 68 | |
| misc | FinalParameters | Parameter request should be final. | 69 | |
| misc | FinalParameters | Parameter response should be final. | 70 |
examples/dyna/ProcessDynaAction.java
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| misc | NewlineAtEndOfFile | File does not end with a newline. | 1 | |
| javadoc | JavadocPackage | Missing package-info.java file. | 1 | |
| header | RegexpHeader | Line does not match expected header line of ' \*\s*Copyright \d{4}(-\d{4}|,\d{4})* The Apache Software Foundation\.'. | 4 | |
| javadoc | JavadocStyle | First sentence should end with a period. | 32 | |
| misc | FinalParameters | Parameter mapping should be final. | 66 | |
| misc | FinalParameters | Parameter form should be final. | 67 | |
| misc | FinalParameters | Parameter request should be final. | 68 | |
| misc | FinalParameters | Parameter response should be final. | 69 |
examples/links/PrepareLinksAction.java
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| misc | NewlineAtEndOfFile | File does not end with a newline. | 1 | |
| header | RegexpHeader | Line does not match expected header line of ' \*\s*Copyright \d{4}(-\d{4}|,\d{4})* The Apache Software Foundation\.'. | 4 | |
| misc | FinalParameters | Parameter mapping should be final. | 71 | |
| misc | FinalParameters | Parameter form should be final. | 72 | |
| misc | FinalParameters | Parameter request should be final. | 73 | |
| misc | FinalParameters | Parameter response should be final. | 74 |
examples/links/ProcessLinksAction.java
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| misc | NewlineAtEndOfFile | File does not end with a newline. | 1 | |
| javadoc | JavadocPackage | Missing package-info.java file. | 1 | |
| header | RegexpHeader | Line does not match expected header line of ' \*\s*Copyright \d{4}(-\d{4}|,\d{4})* The Apache Software Foundation\.'. | 4 | |
| javadoc | JavadocStyle | First sentence should end with a period. | 32 | |
| misc | FinalParameters | Parameter mapping should be final. | 66 | |
| misc | FinalParameters | Parameter form should be final. | 67 | |
| misc | FinalParameters | Parameter request should be final. | 68 | |
| misc | FinalParameters | Parameter response should be final. | 69 |
examples/localization/ProcessLocalizationAction.java
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| misc | NewlineAtEndOfFile | File does not end with a newline. | 1 | |
| javadoc | JavadocPackage | Missing package-info.java file. | 1 | |
| header | RegexpHeader | Line does not match expected header line of ' \*\s*Copyright \d{4}(-\d{4}|,\d{4})* The Apache Software Foundation\.'. | 4 | |
| javadoc | JavadocStyle | First sentence should end with a period. | 36 | |
| misc | FinalParameters | Parameter mapping should be final. | 70 | |
| misc | FinalParameters | Parameter form should be final. | 71 | |
| misc | FinalParameters | Parameter request should be final. | 72 | |
| misc | FinalParameters | Parameter response should be final. | 73 |
examples/logic/PrepareLogicAction.java
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| misc | NewlineAtEndOfFile | File does not end with a newline. | 1 | |
| javadoc | JavadocPackage | Missing package-info.java file. | 1 | |
| header | RegexpHeader | Line does not match expected header line of ' \*\s*Copyright \d{4}(-\d{4}|,\d{4})* The Apache Software Foundation\.'. | 4 | |
| misc | FinalParameters | Parameter mapping should be final. | 75 | |
| misc | FinalParameters | Parameter form should be final. | 76 | |
| misc | FinalParameters | Parameter request should be final. | 77 | |
| misc | FinalParameters | Parameter response should be final. | 78 | |
| coding | MagicNumber | '7' is a magic number. | 87 |
examples/multibox/MultiboxActionForm.java
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| javadoc | JavadocPackage | Missing package-info.java file. | 1 | |
| header | RegexpHeader | Line does not match expected header line of ' \*\s*Copyright \d{4}(-\d{4}|,\d{4})* The Apache Software Foundation\.'. | 4 | |
| javadoc | JavadocStyle | First sentence should end with a period. | 30 | |
| javadoc | JavadocStyle | First sentence should end with a period. | 40 | |
| javadoc | JavadocStyle | First sentence should end with a period. | 43 | |
| javadoc | JavadocStyle | First sentence should end with a period. | 57 | |
| misc | FinalParameters | Parameter mapping should be final. | 63 | |
| misc | FinalParameters | Parameter request should be final. | 63 | |
| misc | FinalParameters | Parameter mapping should be final. | 89 | |
| misc | FinalParameters | Parameter request should be final. | 90 | |
| misc | FinalParameters | Parameter colors should be final. | 123 | |
| misc | FinalParameters | Parameter fruits should be final. | 131 |
examples/multibox/PrepareMultiboxAction.java
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| misc | NewlineAtEndOfFile | File does not end with a newline. | 1 | |
| header | RegexpHeader | Line does not match expected header line of ' \*\s*Copyright \d{4}(-\d{4}|,\d{4})* The Apache Software Foundation\.'. | 4 | |
| misc | FinalParameters | Parameter mapping should be final. | 67 | |
| misc | FinalParameters | Parameter form should be final. | 68 | |
| misc | FinalParameters | Parameter request should be final. | 69 | |
| misc | FinalParameters | Parameter response should be final. | 70 |
examples/multibox/ProcessMultiboxAction.java
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| misc | NewlineAtEndOfFile | File does not end with a newline. | 1 | |
| header | RegexpHeader | Line does not match expected header line of ' \*\s*Copyright \d{4}(-\d{4}|,\d{4})* The Apache Software Foundation\.'. | 4 | |
| javadoc | JavadocStyle | First sentence should end with a period. | 32 | |
| misc | FinalParameters | Parameter mapping should be final. | 66 | |
| misc | FinalParameters | Parameter form should be final. | 67 | |
| misc | FinalParameters | Parameter request should be final. | 68 | |
| misc | FinalParameters | Parameter response should be final. | 69 |
examples/options/BookBean.java
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| header | RegexpHeader | Line does not match expected header line of ' \*\s*Copyright \d{4}(-\d{4}|,\d{4})* The Apache Software Foundation\.'. | 4 | |
| javadoc | JavadocStyle | First sentence should end with a period. | 24 | |
| javadoc | JavadocStyle | First sentence should end with a period. | 33 | |
| javadoc | JavadocStyle | First sentence should end with a period. | 38 | |
| misc | FinalParameters | Parameter isbn should be final. | 50 | |
| misc | FinalParameters | Parameter title should be final. | 50 | |
| javadoc | JavadocStyle | First sentence should end with a period. | 65 |
examples/options/PrepareOptionsAction.java
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| misc | NewlineAtEndOfFile | File does not end with a newline. | 1 | |
| header | RegexpHeader | Line does not match expected header line of ' \*\s*Copyright \d{4}(-\d{4}|,\d{4})* The Apache Software Foundation\.'. | 4 | |
| misc | FinalParameters | Parameter mapping should be final. | 71 | |
| misc | FinalParameters | Parameter form should be final. | 72 | |
| misc | FinalParameters | Parameter request should be final. | 73 | |
| misc | FinalParameters | Parameter response should be final. | 74 | |
| coding | MagicNumber | '3' is a magic number. | 156 | |
| coding | MagicNumber | '4' is a magic number. | 157 | |
| coding | MagicNumber | '5' is a magic number. | 158 |
examples/options/ProcessOptionsAction.java
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| misc | NewlineAtEndOfFile | File does not end with a newline. | 1 | |
| javadoc | JavadocPackage | Missing package-info.java file. | 1 | |
| header | RegexpHeader | Line does not match expected header line of ' \*\s*Copyright \d{4}(-\d{4}|,\d{4})* The Apache Software Foundation\.'. | 4 | |
| javadoc | JavadocStyle | First sentence should end with a period. | 32 | |
| misc | FinalParameters | Parameter mapping should be final. | 66 | |
| misc | FinalParameters | Parameter form should be final. | 67 | |
| misc | FinalParameters | Parameter request should be final. | 68 | |
| misc | FinalParameters | Parameter response should be final. | 69 |
examples/simple/ProcessSimpleAction.java
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| misc | NewlineAtEndOfFile | File does not end with a newline. | 1 | |
| javadoc | JavadocPackage | Missing package-info.java file. | 1 | |
| header | RegexpHeader | Line does not match expected header line of ' \*\s*Copyright \d{4}(-\d{4}|,\d{4})* The Apache Software Foundation\.'. | 4 | |
| javadoc | JavadocStyle | First sentence should end with a period. | 32 | |
| misc | FinalParameters | Parameter mapping should be final. | 66 | |
| misc | FinalParameters | Parameter form should be final. | 67 | |
| misc | FinalParameters | Parameter request should be final. | 68 | |
| misc | FinalParameters | Parameter response should be final. | 69 |
examples/simple/SimpleActionForm.java
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| header | RegexpHeader | Line does not match expected header line of ' \*\s*Copyright \d{4}(-\d{4}|,\d{4})* The Apache Software Foundation\.'. | 4 | |
| javadoc | JavadocStyle | First sentence should end with a period. | 31 | |
| javadoc | JavadocStyle | First sentence should end with a period. | 41 | |
| javadoc | JavadocStyle | First sentence should end with a period. | 44 | |
| javadoc | JavadocStyle | First sentence should end with a period. | 47 | |
| javadoc | JavadocStyle | First sentence should end with a period. | 50 | |
| javadoc | JavadocStyle | First sentence should end with a period. | 53 | |
| javadoc | JavadocStyle | First sentence should end with a period. | 56 | |
| javadoc | JavadocStyle | First sentence should end with a period. | 59 | |
| misc | FinalParameters | Parameter mapping should be final. | 79 | |
| misc | FinalParameters | Parameter request should be final. | 79 | |
| misc | FinalParameters | Parameter mapping should be final. | 104 | |
| misc | FinalParameters | Parameter request should be final. | 105 | |
| misc | FinalParameters | Parameter color should be final. | 185 | |
| misc | FinalParameters | Parameter confirm should be final. | 193 | |
| misc | FinalParameters | Parameter hidden should be final. | 201 | |
| misc | FinalParameters | Parameter message should be final. | 209 | |
| misc | FinalParameters | Parameter name should be final. | 217 | |
| misc | FinalParameters | Parameter rating should be final. | 225 | |
| misc | FinalParameters | Parameter secret should be final. | 233 |
examples/token/PrepareTokenAction.java
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| misc | NewlineAtEndOfFile | File does not end with a newline. | 1 | |
| javadoc | JavadocPackage | Missing package-info.java file. | 1 | |
| header | RegexpHeader | Line does not match expected header line of ' \*\s*Copyright \d{4}(-\d{4}|,\d{4})* The Apache Software Foundation\.'. | 4 | |
| misc | FinalParameters | Parameter mapping should be final. | 67 | |
| misc | FinalParameters | Parameter form should be final. | 68 | |
| misc | FinalParameters | Parameter request should be final. | 69 | |
| misc | FinalParameters | Parameter response should be final. | 70 |
examples/token/ProcessTokenAction.java
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| misc | NewlineAtEndOfFile | File does not end with a newline. | 1 | |
| header | RegexpHeader | Line does not match expected header line of ' \*\s*Copyright \d{4}(-\d{4}|,\d{4})* The Apache Software Foundation\.'. | 4 | |
| javadoc | JavadocStyle | First sentence should end with a period. | 35 | |
| misc | FinalParameters | Parameter mapping should be final. | 69 | |
| misc | FinalParameters | Parameter form should be final. | 70 | |
| misc | FinalParameters | Parameter request should be final. | 71 | |
| misc | FinalParameters | Parameter response should be final. | 72 |
examples/validator/CustomValidator.java
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| javadoc | JavadocPackage | Missing package-info.java file. | 1 | |
| header | RegexpHeader | Line does not match expected header line of ' \*\s*Copyright \d{4}(-\d{4}|,\d{4})* The Apache Software Foundation\.'. | 4 | |
| javadoc | JavadocStyle | First sentence should end with a period. | 34 | |
| design | HideUtilityClassConstructor | Utility classes should not have a public or default constructor. | 39 | |
| javadoc | JavadocStyle | First sentence should end with a period. | 52 | |
| javadoc | JavadocMethod | @return tag should be present and have description. | 66 | |
| misc | FinalParameters | Parameter bean should be final. | 67 | |
| javadoc | JavadocMethod | Expected @param tag for 'bean'. | 67 | |
| misc | FinalParameters | Parameter va should be final. | 68 | |
| javadoc | JavadocMethod | Expected @param tag for 'va'. | 68 | |
| misc | FinalParameters | Parameter field should be final. | 69 | |
| javadoc | JavadocMethod | Expected @param tag for 'field'. | 69 | |
| misc | FinalParameters | Parameter errors should be final. | 70 | |
| javadoc | JavadocMethod | Expected @param tag for 'errors'. | 70 | |
| misc | FinalParameters | Parameter validator should be final. | 71 | |
| javadoc | JavadocMethod | Expected @param tag for 'validator'. | 71 | |
| misc | FinalParameters | Parameter request should be final. | 72 | |
| javadoc | JavadocMethod | Expected @param tag for 'request'. | 72 |
examples/validator/ProcessValidatorAction.java
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| misc | NewlineAtEndOfFile | File does not end with a newline. | 1 | |
| header | RegexpHeader | Line does not match expected header line of ' \*\s*Copyright \d{4}(-\d{4}|,\d{4})* The Apache Software Foundation\.'. | 4 | |
| javadoc | JavadocStyle | First sentence should end with a period. | 32 | |
| misc | FinalParameters | Parameter mapping should be final. | 66 | |
| misc | FinalParameters | Parameter form should be final. | 67 | |
| misc | FinalParameters | Parameter request should be final. | 68 | |
| misc | FinalParameters | Parameter response should be final. | 69 |


